Skip to content

fix(plans): land trailing rubocop/self_serve commit from #15 onto main #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rrader26 merged 1 commit into from
Jul 6, 2026
Merged

fix(plans): land trailing rubocop/self_serve commit from #15 onto main #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/graphql/resolvers/customer_portal/available_plans_resolver.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ class AvailablePlansResolver < Resolvers::BaseResolver

description "Lists plans available to the customer portal user, filtered by product"

argument :product_key, String, required: false,
description: "Filter to plans whose code starts with `${product_key}-`"
argument :exclude_current, Boolean, required: false, default_value: false,
description: "Omit plans the customer already has an active subscription to"
argument :product_key, String, required: false,
description: "Filter to plans whose code starts with `${product_key}-`"

type [Types::Plans::Object], null: false

Expand Down
2 changes: 1 addition & 1 deletion app/services/plans/create_service.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ def call
trial_period: args[:trial_period],
bill_charges_monthly: bill_charges_monthly(args),
bill_fixed_charges_monthly: bill_fixed_charges_monthly(args),
self_serve: args[:self_serve].nil? ? true : args[:self_serve]
self_serve: args[:self_serve] != false
)

chargeables_validation_result = Plans::ChargeablesValidationService.call(
Expand Down
Loading