sdk: reflect() + proto re-vendor (8 new RPCs classified) - #10
Merged
Conversation
Vendored proto was behind engine main (d963308 -> 5e381923). The typed- attribute, healthcare, and behavior-discovery resources were already implemented in the client but their RPCs weren't recorded in coverage.json, so the drift guard had nothing to check them against. Classify all 8 as covered: UpsertAttributeDef -> typed.registerAttribute QueryAttributeDefs -> typed.listAttributes SaveTypedObservations -> typed.ingest / typed.enqueue QueryTypedObservations -> typed.queryObservations GetAccumulator -> typed.accumulator GetHealthProfile -> health.getProfile GetCohortHealthRisk -> health.getCohortRisk DiscoverBehaviors -> behaviors.discover check:proto now green: 43 RPCs, 38 covered, 5 internal. typecheck + build pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Surface the engine's new Reflect RPC (reflection / insight synthesis).
memory.admin.reflect({ userId?, maxSources?, maxInsights?, dryRun? })
POSTs /admin/memory/reflect and returns synthesized insights with
provenance. Adds ReflectRequest / ReflectResult / Insight types.
check:proto green: 44 RPCs, 39 covered, 5 internal.
Note: the TS Fastify shell still needs the POST /admin/memory/reflect
route wired to the gRPC Reflect call for this to work over REST; the
engine RPC itself is live.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings
@thinkfleet/memory-sdkback in sync with the engine's RPC surface.5b917ef— re-vendor engine proto (d963308→5e381923) and classify the 8 RPCs whose resources already existed but weren't recorded incoverage.json(typed attributes, healthcare, behavior discovery). Drift guard was green-but-blind for these.5511d9c—memory.admin.reflect({ userId?, maxSources?, maxInsights?, dryRun? })for the engine's new Reflect RPC (reflection / insight synthesis, ThinkfleetAI/thinkfleet-memory-engine#49). AddsReflectRequest/ReflectResult/Insighttypes. Re-vendor proto →7f1c2be.check:protogreen (44 RPCs, 39 covered, 5 internal); typecheck + build pass.Follow-up: the TS Fastify shell still needs
POST /admin/memory/reflectwired to the gRPCReflectcall for this to work over REST. The engine RPC itself is functional (callable via gRPC today). Merge after the engine PR.🤖 Generated with Claude Code