fix(consent): cap consent lookup limit at 500 (engine max) - #9
Merged
Conversation
findActiveConsent listed memories with limit:1000, but the engine rejects any limit > 500 (querystring/limit must be <= 500), so every consent op (optOut/optIn/getStatus) hard-failed. Use 500, the max allowed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
findActiveConsentlisted memories withlimit: 1000, but the engine rejects anylimit > 500(querystring/limit must be <= 500). So everytf.memory.consent.*operation (optOut/optIn/getStatus) hard-failed. Found while validating against QA.Fix: use
limit: 500(the max allowed).✅
npm run typecheck+npm run buildclean.Note: if a subject ever has >500 memories, the client-side CONSENT filter could miss older consent records — a follow-up could query consent-typed memories directly or paginate. This PR just fixes the hard failure.
🤖 Generated with Claude Code