Chore/move to workspace#3
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 075dda4251
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let (status, bytes) = self.get_bytes(&url)?; | ||
|
|
There was a problem hiding this comment.
UreqRustdocFetcher::fetch is declared async but performs a synchronous ureq request and synchronous zstd decode inline. This fetcher is wired into the Axum server request path, so each cache miss can block a Tokio worker thread for both network I/O and CPU decode, which sharply reduces concurrency and can cause tail-latency spikes/timeouts under load compared with the previous non-blocking implementation.
Useful? React with 👍 / 👎.
| if path == "/" { | ||
| return text_response( | ||
| 200, | ||
| "md-docrs-worker - GET /<crate>[/<version>][/<path>] for Markdown docs\n", | ||
| "text/plain; charset=utf-8", |
There was a problem hiding this comment.
spec query requests before root short-circuit
The worker returns the root banner immediately when path == "/", so query-form requests like /?spec=anyhow::Error are never interpreted as render requests. That breaks the query flow advertised by the repo helper commands and makes root-query clients always receive the static help text instead of Markdown output.
Useful? React with 👍 / 👎.
| let spec = ItemSpec { | ||
| crate_name: crate_name.to_string(), | ||
| version: version.to_string(), | ||
| target: None, | ||
| path, |
There was a problem hiding this comment.
The worker always constructs ItemSpec with target: None, so target-specific lookups are silently forced to the default docs.rs target. Any client request that intends to resolve cfg/target-dependent items (including the curl-worker-target workflow in justfile) cannot get the intended target’s docs and may return incorrect/missing results.
Useful? React with 👍 / 👎.
ThomAub
force-pushed
the
chore/move-to-workspace
branch
from
89c5589 to
dfc745d
Compare
1 participant
No description provided.