Skip to content

chore: Standardize and rewrite README files#5

Merged
ThomAub merged 1 commit into
mainfrom
chore/fix-split-readme
Apr 23, 2026
Merged

chore: Standardize and rewrite README files#5
ThomAub merged 1 commit into
mainfrom
chore/fix-split-readme

Conversation

@ThomAub
Copy link
Copy Markdown
Owner

@ThomAub ThomAub commented Apr 23, 2026

Rename workspace from md-docrs-proxy to md-docrs and harmonize README content across top-level and crate docs (crates/md-docrs-*, wasm/, zig/). Clarify usage, build, and release instructions.

Rename workspace from md-docrs-proxy to md-docrs and
harmonize README content across top-level and crate docs
(crates/md-docrs-*, wasm/, zig/). Clarify usage, build, and
release instructions.
@ThomAub ThomAub merged commit 8ba9251 into main Apr 23, 2026
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c79effdb3d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +40 to +41
- `GET /?spec=<crate[@version][::path::to::item]>`
- `GET /?spec=<crate[@version][::path::to::item]>&target=<triple>`
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Remove unsupported ?spec server route documentation

The README now documents GET /?spec=... routes, but md-docrs-server does not implement them: the router only binds /, /healthz, and path-based crate routes, and root() always returns a static usage string instead of dispatching by query (crates/md-docrs-server/src/server.rs, router/root). Users following these examples will get a non-Markdown usage response rather than rendered docs.

Useful? React with 👍 / 👎.

- `GET /?spec=<crate[@version][::path::to::item]>&target=<triple>`
- `GET /healthz`

The server also accepts `?target=<triple>` on path-based requests.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Stop claiming path requests honor ?target in server README

The new docs state that path-based requests accept ?target=<triple>, but the server never reads query parameters and always constructs ItemSpec with target: None in serve(...) (crates/md-docrs-server/src/server.rs). This is a behavior mismatch: callers who pass ?target= will silently get default-target docs, which can produce incorrect item pages for target-specific APIs.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant