feature: prevent database writes when the topic is idle#4
Merged
Conversation
The busy waiting loop, that polls the next batches causes a modification
to the database (sets the lock)
this causes tools like litestream to write wal files to their
replicas every poll interval
this makes a restore incredibly slow and causes a constant drain on
the cpu.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The busy waiting loop, that polls the next batches causes a modification to the database (sets the lock).
This causes tools like litestream to write wal files to their replicas every poll interval.
This makes a restore incredibly slow and causes a constant drain on the cpu.
Lock + read operation are in the same transaction. I think I can just cancel the transaction if the batch size is 0 to prevent the unneccessary write.
Here is an example of another attempt to achieve the same result: https://github.com/sandpapersoftware/watermillsqlite