Allow coding agents to author safe tool-source proposals#282
Merged
Conversation
pengfei-threemoonslab
marked this pull request as ready for review
July 20, 2026 22:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is the narrow contract-v18 UX repair that separates proposal authorship from approval for missing Shipgate coverage.
tool_sourcesrows.shipgate.yamltrust-root diff still requires human review.shipgate.yamlexplicitly declares them.Security boundary
The proposal-safe classifier requires both manifest sides to resolve and validate, all non-
tool_sourcesvalues and existing rows to remain identical, and the diff to be insertion-only. The exemption is available only when exactly one diff record targetsshipgate.yaml; duplicate records remain path-wide unclassified and human-routed regardless of ordering. Added rows are limited to built-in adapters andid/type/path/mode;trust,optional, custom adapters, comments, blank additions, removals/reordering, mixed edits, nonexistent/out-of-tree/root paths, and symlinked artifacts remain human-routed.For Codex plugin packages, the package directory and
.codex-plugin/plugin.jsonmust exist without symlink traversal. A safe classification authorizes authorship only—it supplies no effect, authority, binding, policy, approval, merge, or execution claim.The fixture exclusion only affects undeclared-surface inference. An explicitly declared test/fixture path still routes through verify.
Validation
python -m ruff check .python scripts/generate_schemas.py --checkpython -m pytest tests/test_packaging.py -q: 8 passed.shipgate.yamlregressions pass in both safe-first and unsafe-first orderings.services/fixtures/remains undeclared-surface detectable; conventional test/golden and explicitly declared fixture cases remain covered.origin/main: base/head succeeded,control.state=complete,release_decision=passed,merge_verdict=mergeable.After this merges, the release-candidate branch can use the new mode to propose the missing Codex plugin package declaration, obtain normal human review over the concrete diff, and resume the v0.16.0 ceremony.