This repository was archived by the owner on Mar 20, 2018. It is now read-only.
Implementation of Discordian Chronology#2
Open
robfletcher wants to merge 5 commits intoThreeTen:masterfrom
Open
Implementation of Discordian Chronology#2robfletcher wants to merge 5 commits intoThreeTen:masterfrom
robfletcher wants to merge 5 commits intoThreeTen:masterfrom
Conversation
Hail Eris! All Hail Discordia!
Member
|
Looks good. I just need to establish the licensing. Are you willing to license this under the same terms (BSD 3 clause) as the rest of the threetenbp-extra project, effectively assigning copyright to myself and Michael. This can be done by adding a license header to the three files in your copy. Thanks. |
Author
|
Sorry, I keep forgetting to do this! Of course, I'm happy to assign copyright. I've also added an |
Member
|
Thanks, I'll try to get around to merging this soon... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've updated the implementation to conform to the slightly different interface. Specifically
plusand the 2 overloaded versions ofperiodUntilare new from the implementation I did originally for the ThreeTen/threetenbp project.