Open
Conversation
Change is_precomputed_minmax = False for HRFC (for experiments)
motiwari
commented
Jul 29, 2022
Contributor
Author
motiwari
left a comment
motiwari
left a comment
There was a problem hiding this comment.
@vxbrandon 2 inline questions
…ompare_runtimes.py
…plicated code. Also cleaned up Jeys real_experiments.py and regression_experiment.py
…some SKLEARN to SKLEARN_REGRESSION to avoid naming collision
…fs to logs dir, choosing datasets
…t_experiments # Conflicts: # experiments/datasets/data_loader.py # experiments/runtime_exps/compare_runtimes.py
…unately contains the bug about solver reduction to each feature being an arm, but should be ok to use these for Table 1
…g good except blog dataset
…re fit in budget experiments
…o fixing bincounts to bincount
- Find the best hyperparams setting for table 5 experiment.
…rest into reproducec_experiments
…from 2 to 5 2. Implement a function that converts a target vector in classification problem to a vector of contiguous integers 3. Update requirements.txt 4. Fix bugs that the codes don't log the files in the right place depending on where we run the codes
Reproduce experiments
2. Increase max depth to 5 in runtime experiments on sklearn regression dataset.
…25, conf_multiplier=1, MAB outperforms RANDOM_SOLVER
…eirs still slightly worse
Random baseline merge for skeleton code for random baseline
…ith more generous hyperparameters, Table 1 forest covtype accuracies a bit worse, and Table 2 some rows are identical, Scaling plots look worse than linear on smaller dataset (MNIST). Other than that, ok
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parsing Jey's changes