v1.10.2#284
Merged
Merged
Conversation
Update Translations
Limit CI runs by adding path filters to pull_request triggers: PHP workflows now only run for '**/*.php' and Python checks run for 'resources/**/*.py'. Add a new js-check workflow that runs on PRs to beta for '**/*.js', sets up Node 22, and runs `node --check` on JS files (excluding node_modules) to catch syntax errors. This reduces unnecessary workflow executions and introduces basic JavaScript syntax validation.
Add workflow_dispatch to checkPHP, checkPHPCompat, checkPython, and js-check workflows so they can be triggered manually from the Actions UI. Existing triggers (branch/path filters) remain unchanged.
Update the GitHub Actions workflow (.github/workflows/js-check.yml) to use actions/setup-node@v5 instead of @v4. The node-version remains '22'; this change moves the workflow to the newer setup-node major release.
Tighten filename sanitization for uploaded custom sounds: apply sanitizeAccent(), transliterate to ASCII, convert to lowercase, replace non-alphanumeric/._- characters with underscores, and strip leading/trailing underscores or hyphens before the extension. Keeps existing validation to prevent empty filename bases after cleaning. Also increment pluginVersion to 1.10.2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to file handling, workflow automation, and JavaScript code checks. The most significant changes include enhanced filename sanitization for custom sound uploads, the addition of a JavaScript syntax checking workflow, and refined workflow triggers to limit checks to relevant files. The plugin version is also incremented to reflect these updates.
File handling improvements:
ttscast.ajax.phpby usingsanitizeAccent, converting to lowercase, refining allowed characters, and trimming unwanted underscores or hyphens. This reduces the risk of invalid or unsafe filenames.Workflow automation enhancements:
js-check.yml) to automatically check JavaScript syntax on pull requests targeting thebetabranch, ensuring code quality for.jsfiles.checkPHP.yml,checkPHPCompat.yml,checkPython.yml) to only run on pull requests that modify relevant file types (.phpor.py), reducing unnecessary runs and improving CI efficiency. [1] [2] [3]Versioning:
info.jsonfrom1.10.1to1.10.2to reflect these changes.