v1.10.4#287
Merged
Merged
Conversation
Upgrade JeedomTTS failure paths from warnings to errors in the daemon, including HTTP status failures and missing TTS files. Also make `TestTTS` and main `TTS` processing return `False` immediately when JeedomTTS output is invalid, so bad responses no longer continue as if successful.
Updates two error logs in `ttscastd.py` (`TestTTS` and `TTS`) to report that no audio file was generated, instead of the vaguer "incorrect output" message. This makes failure diagnostics more explicit when JeedomTTS returns no usable audio payload.
Updates plugin metadata to version 1.10.4 and adjusts Jeedom TTS daemon log messages to explicitly label Jeedom file paths/errors. This makes troubleshooting missing generated TTS files clearer in mixed TTS contexts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the TTS Cast plugin to version 1.10.4 and improves error handling and logging in the TTS generation process. The main changes focus on making error messages more explicit and ensuring that failures in generating TTS files are properly reported and handled.
Error handling and logging improvements:
logging.warningcalls tologging.errorinttscastd.pyto better reflect the severity of TTS file generation failures and HTTP errors. The log messages were also clarified for better debugging.generateTestTTSandgetTTSfunctions, added areturn Falsestatement when TTS file generation fails, ensuring that calling code is properly notified of the failure. The error messages were updated to specify that no audio file was generated. [1] [2]Version update:
1.10.3to1.10.4inplugin_info/info.json.