Skip to content

add ssh connection#24

Merged
Tiagospem merged 127 commits into
devfrom
ssh
May 22, 2025
Merged

add ssh connection#24
Tiagospem merged 127 commits into
devfrom
ssh

Conversation

@Tiagospem
Copy link
Copy Markdown
Owner

No description provided.

Tiagospem added 30 commits May 16, 2025 14:29
…le with connection management, command execution, and file operations
…unctionality and updating progress documentation
@Tiagospem Tiagospem requested a review from Copilot May 19, 2025 12:52
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces SSH connection support by migrating to an AppConnection model and integrating SSH tunneling throughout key modules. Key changes include refactoring connection configurations (renaming db_config to dbConfig and replacing MysqlConnection with AppConnection) in modules like monitoring, migrations, and database restore, as well as updating error handling and documentation to support SSH connectivity.

Reviewed Changes

Copilot reviewed 87 out of 87 changed files in this pull request and generated no comments.

Show a summary per file
File Description
electron/modules/monitoring.ts Updated connection and trigger handling with AppConnection usage
electron/modules/migrations.ts Switched to use appConnection for database migrations
electron/modules/database-restore.ts Refactored connection handling and error logging using AppConnection
electron/main/index.ts Integrated registration for SSH handlers and closing SSH tunnels
electron/helpers/mysql.ts Enhanced SSH tunneling support and connection options adjustments
docs/* Updated and removed legacy SSH documentation to align with new changes
.eslintrc.js, .eslintignore Removed ESLint configuration files (ensure linting is handled elsewhere)
Comments suppressed due to low confidence (3)

electron/modules/database-restore.ts:226

  • The local variable 'AppConnection' shadows the imported type from '../../src/types/ssh-connection'. Consider renaming it (e.g., 'appConnectionConfig') to avoid confusion.
const AppConnection = {

.eslintrc.js:1

  • The removal of the ESLint configuration file may affect code style enforcement. Please confirm that linting is configured elsewhere in the project.
module.exports = { ... }

docs/postgresql-implementation/06-ui-components.md:94

  • Ensure that the renaming from 'db_config' to 'dbConfig' is applied consistently across all components and documentation to avoid discrepancies in connection configuration handling.
host: newConnection.value.dbConfig.host,

Tiagospem added 25 commits May 20, 2025 08:52
@Tiagospem Tiagospem merged commit 48eaf1f into dev May 22, 2025
3 checks passed
@Tiagospem Tiagospem deleted the ssh branch May 22, 2025 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants