feat: bump version to 1.2.3 and implement app quitting logic with res…#26
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR bumps the package version and adds graceful app quitting logic with resource cleanup.
- Bump version from 1.2.2 to 1.2.3 in package.json
- Expose a new
quitAppIPC method in the preload script - Introduce
isQuittingflag, anapp-quithandler,performCleanup()routine, and update window event handlers to run cleanup before exit
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Updated "version" from "1.2.2" to "1.2.3". |
| electron/preload/index.ts | Added quitApp method on the ipcRenderer bridge to invoke 'app-quit'. |
| electron/main/index.ts | Added isQuitting flag, ipcMain.handle('app-quit'), performCleanup() helper, and updated window close handlers and window-all-closed logic for cleanup. |
Comments suppressed due to low confidence (2)
electron/main/index.ts:374
- The cleanup routine may run multiple times (once in each window's 'close' handler and again here). Consider guarding
performCleanup()with a flag or centralizing the cleanup call to avoid duplicate resource shutdowns.
app.on('window-all-closed', () => {
electron/preload/index.ts:42
- There’s no TypeScript definition for the new
quitAppmethod. Add or update the globalWindowinterface (or a.d.tsfile) sowindow.ipcRenderer.quitAppis properly typed.
quitApp: () => ipcRenderer.invoke('app-quit'),
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ource cleanup