Skip to content

feat: bump version to 1.2.3 and implement app quitting logic with res…#26

Merged
Tiagospem merged 1 commit into
devfrom
close-window
May 23, 2025
Merged

feat: bump version to 1.2.3 and implement app quitting logic with res…#26
Tiagospem merged 1 commit into
devfrom
close-window

Conversation

@Tiagospem
Copy link
Copy Markdown
Owner

…ource cleanup

@Tiagospem Tiagospem requested a review from Copilot May 22, 2025 14:07
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR bumps the package version and adds graceful app quitting logic with resource cleanup.

  • Bump version from 1.2.2 to 1.2.3 in package.json
  • Expose a new quitApp IPC method in the preload script
  • Introduce isQuitting flag, an app-quit handler, performCleanup() routine, and update window event handlers to run cleanup before exit

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
package.json Updated "version" from "1.2.2" to "1.2.3".
electron/preload/index.ts Added quitApp method on the ipcRenderer bridge to invoke 'app-quit'.
electron/main/index.ts Added isQuitting flag, ipcMain.handle('app-quit'), performCleanup() helper, and updated window close handlers and window-all-closed logic for cleanup.
Comments suppressed due to low confidence (2)

electron/main/index.ts:374

  • The cleanup routine may run multiple times (once in each window's 'close' handler and again here). Consider guarding performCleanup() with a flag or centralizing the cleanup call to avoid duplicate resource shutdowns.
app.on('window-all-closed', () => {

electron/preload/index.ts:42

  • There’s no TypeScript definition for the new quitApp method. Add or update the global Window interface (or a .d.ts file) so window.ipcRenderer.quitApp is properly typed.
quitApp: () => ipcRenderer.invoke('app-quit'),

@Tiagospem Tiagospem merged commit 6d66eef into dev May 23, 2025
3 checks passed
@Tiagospem Tiagospem deleted the close-window branch May 23, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants