Ssh enhancements#28
Merged
Merged
Conversation
…es with fallback to SFTP
…leEditor and RemoteFileExplorer
…leEditor and RemoteFileExplorer
… state persistence
…tation and fix path construction issues
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements SSH enhancements and related optimizations, including improved Monaco editor configuration and an enhanced remote file explorer with directory tree support. Key changes include:
- Adding optimized SSH methods (list, read, write, exists) and their corresponding IPC handlers.
- Integrating the optimized SSH service into existing remote file and editor components.
- Enhancing Monaco editor configuration and adding a new directory tree sidebar component.
Reviewed Changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| vite.config.ts | Added dependency inclusion for monaco-editor and NODE_ENV definition |
| src/utils/monaco-config.ts | Introduced centralized Monaco editor configuration |
| src/store/fileExplorer.ts | New Pinia store for managing remote file explorer state with expanded directory tree |
| src/services/remote-file-service.ts | Updated remote file methods to utilize optimized SSH calls with fallbacks |
| src/services/optimized-ssh-service.ts | New service providing optimized SSH operations with caching |
| src/composables/useSQLEditor.ts | Updated to call configureMonaco and use optimized SSH service for file operations |
| src/components/RemoteFileExplorer.vue | Enhanced remote file explorer with sidebar integration and improved path handling |
| src/components/RemoteFileEditor.vue | Switched to optimized SSH service for file read/write operations |
| src/components/DotEnvEditor.vue | Integrated Monaco configuration |
| src/components/DirectoryTreeSidebar.vue | New component providing a collapsible directory tree sidebar |
| src/components/DirectoryTreeNode.vue | Added tree node rendering with proper event propagation |
| electron/preload/index.ts | Exposed new optimized SSH IPC methods |
| electron/modules/ssh.ts | Updated SSH command execution to use optimized SSH manager with error handling |
| electron/helpers/optimized-ssh.ts | Introduced connection pooling and optimized SSH command execution |
| electron/helpers/ssh.ts | Removed unused debug code and redundant safety checks |
| electron/helpers/mysql.ts | Minor adjustments in connection pool handling |
| CLAUDE.md & .claude/settings.local.json | Documentation and configuration updates to support new SSH and build processes |
Comments suppressed due to low confidence (1)
src/services/optimized-ssh-service.ts:121
- The replace operation on 'content' does not update the string since its result is not reassigned, potentially causing issues with escaping single quotes. Please assign the result back to 'content' (e.g., content = content.replace(/'/g, "'"'"'")).
content.replace(/'/g, "'"'"'");
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.