fix: check winboat disk space instead of its parent path#418
Draft
GetPsyched wants to merge 1 commit intoTibixDev:mainfrom
Draft
fix: check winboat disk space instead of its parent path#418GetPsyched wants to merge 1 commit intoTibixDev:mainfrom
GetPsyched wants to merge 1 commit intoTibixDev:mainfrom
Conversation
Collaborator
|
My suggestion in #404 was purely because it didn't fundamentally change the intent of that check. |
waffles-dev
requested changes
Oct 27, 2025
| const isWinboatPathCreated = false; | ||
| try { | ||
| fs.mkdirSync(winboatPath, { recursive: true }); | ||
| isWinboatPathCreated = true; |
Collaborator
There was a problem hiding this comment.
how does this work when isWinboatPathCreated is a constant?
Author
There was a problem hiding this comment.
Whoops. That bool was a last-minute thing so it went untested
| const diskSpace = await checkDiskSpace(parentPath); | ||
| const diskSpace = await checkDiskSpace(isWinboatPathCreated ? winboatPath : parentPath); | ||
| if (isWinboatPathCreated) { | ||
| await fs.rm(winboatPath, { recursive: true }); |
Collaborator
There was a problem hiding this comment.
Error: Object literal may only specify known properties, and 'recursive' does not exist in type 'NoParamCallback`
Author
There was a problem hiding this comment.
Interesting; where are you seeing this error? I had a lot of trouble seeing any errors. I had to rely solely on if things worked or not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #404
I personally don't like this approach as this breaks general expectations I'd have as a user. I better like (with bias) the approach I suggested here.
Marking this as draft until there's more discussion on the tracking issue.