-
Notifications
You must be signed in to change notification settings - Fork 0
[Snyk] Security upgrade axios from 0.24.0 to 1.13.5 #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -33,7 +33,7 @@ | |
| "node": ">=14" | ||
| }, | ||
| "dependencies": { | ||
| "axios": "^0.24.0", | ||
| "axios": "^1.13.5", | ||
|
||
| "chalk": "^4.1.2", | ||
| "chokidar": "^3.5.2", | ||
| "commander": "^8.3.0", | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This security upgrade is incomplete. The monorepo has multiple packages that depend on axios 0.24.0, including packages/cli and packages/youtill. Both of these packages need to be upgraded to the same axios version to fix the security vulnerability consistently across the codebase. Additionally, packages/cli depends on gritenv (this package), which will create a dependency conflict: cli will require both axios@^0.24.0 (its direct dependency) and axios@^1.13.5 (via gritenv). All packages using axios should be upgraded together in this PR.