Fix documentation: correct JVM memory floor values (1024M/2048M)#64
Merged
Fix documentation: correct JVM memory floor values (1024M/2048M)#64
Conversation
Co-authored-by: TimInTech <129355283+TimInTech@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix installer script Bash problem for LXC container
Fix documentation: correct JVM memory floor values (1024M/2048M)
Nov 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request – Simulation Only
Summary
The README incorrectly documented JVM memory floor values as
256M/448M. The actual implementation insetup_minecraft.shandsetup_minecraft_lxc.shuses1024M(Xms) and2048M(Xmx) as enforced minimums in the RAM autosizing logic.This PR updates README.md line 169 to reflect the correct floor values that have been implemented since commit 8982f0c.
Changed:
README.md: Updated JVM memory documentation fromfloors 256M/448Mtofloors 1024M/2048MChecklist
SIMULATION.mdupdated to reflect behavior and risks.Testing (Simulation)
No functional changes to scripts. Documentation now matches the RAM autosizing implementation:
ShellCheck validation passes. No rollback needed—documentation change only.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.