Skip to content
This repository was archived by the owner on Jan 9, 2024. It is now read-only.

fix: Handle empty playlist #122

Open
Hazmi35 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: Handle empty playlist #122

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ede0a8f
fix: Handle empty playlist
Hazmi35 Aug 30, 2021
6b780f0
fix: Use undefined instead of null
Hazmi35 Aug 30, 2021
d3519ab
fix: Use empty array instead throwing an error
Hazmi35 Sep 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions lib/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,11 +66,14 @@ const main = module.exports = async(linkOrId, options, rt = 3) => {
};

// Parse videos
const rawVideoList = parsed.json.contents
const playlistVideoListRenderer = parsed.json.contents
.twoColumnBrowseResultsRenderer.tabs[0].tabRenderer.content
.sectionListRenderer.contents[0]
.itemSectionRenderer.contents[0]
.playlistVideoListRenderer.contents;
.playlistVideoListRenderer;
Copy link
Copy Markdown
Author

@Hazmi35 Hazmi35 Aug 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could use optional chaining here but that requires node v14.5.0 or above, so I used the ternary operator to be compatible with node v8. I do recommend you bump node to v14.5.0 or above because v8 is EOL and v12 is going to EOL next year

Copy link
Copy Markdown
Author

@Hazmi35 Hazmi35 Aug 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With optional chaining the updated code should look like this

const rawVideoList = parsed.json.contents
    .twoColumnBrowseResultsRenderer.tabs[0].tabRenderer.content
    .sectionListRenderer.contents[0]
    .itemSectionRenderer.contents[0]
    .playlistVideoListRenderer?.contents;

if (rawVideoList === undefined) throw new Error('Playlist is empty');

Copy link
Copy Markdown
Author

@Hazmi35 Hazmi35 Sep 8, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the current changes, it would be like this with optional chaining

const playlistVideoListRenderer = parsed.json.contents
    .twoColumnBrowseResultsRenderer.tabs[0].tabRenderer.content
    .sectionListRenderer.contents[0]
    .itemSectionRenderer.contents[0]
    .playlistVideoListRenderer?.contents ?? [];


const rawVideoList = playlistVideoListRenderer ? playlistVideoListRenderer.contents : [];

resp.items = rawVideoList.map(PARSE_ITEM).filter(a => a).filter((_, index) => index < opts.limit);

// Adjust tracker
Expand Down