chore: improve name for recently introduced MoveDirector API #2058
+14
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request renames the assignValueAndInsert method to assignValueAndAdd in the MoveDirector API to align with Java's java.util.List naming conventions. This is part of the preview API for the Neighborhoods feature.
Changes:
- Renamed
assignValueAndInsert()toassignValueAndAdd()across the API and implementation - Updated javadoc to explicitly reference
List#add(int, Object)andList#set(int, Object)for clarity - Improved documentation wording, changing "later values" to "subsequent values"
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
core/src/main/java/ai/timefold/solver/core/preview/api/move/builtin/ListAssignMove.java |
Updated method call from assignValueAndInsert to assignValueAndAdd |
core/src/main/java/ai/timefold/solver/core/preview/api/move/MutableSolutionView.java |
Renamed method signature, updated deprecated method, added List import, and improved javadoc references |
core/src/main/java/ai/timefold/solver/core/impl/move/MoveDirector.java |
Renamed method implementation to match new API signature |
core/src/main/java/ai/timefold/solver/core/preview/api/move/MutableSolutionView.java
Show resolved
Hide resolved
triceo
commented
Jan 29, 2026
core/src/main/java/ai/timefold/solver/core/preview/api/move/MutableSolutionView.java
Outdated
Show resolved
Hide resolved
|
Christopher-Chianelli
approved these changes
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way, it is consistent with what java.util.List does.