Skip to content

Refactor styles and remove legacy CSS files#18

Open
Timidan wants to merge 3 commits intofeat/phase4-wallet-gatefrom
feat/cleanup
Open

Refactor styles and remove legacy CSS files#18
Timidan wants to merge 3 commits intofeat/phase4-wallet-gatefrom
feat/cleanup

Conversation

@Timidan
Copy link
Copy Markdown
Owner

@Timidan Timidan commented May 6, 2026

  • Consolidated button styles and removed unused classes from SimulationResultsPage.css.
  • Deleted SimulatorWorkbench.css as its styles are now integrated into other CSS files.
  • Removed redundant styles from StackedOverview.css, TokenMovementsPanel.css, and design-tokens.css.
  • Updated type definitions in contractInfo.ts, debug.ts, and transaction.ts by removing unused types.
  • Refactored utility functions in diamondFacetFetcher.ts, resultFormatter.ts, traceDecoder modules, and universalTokenDetector.ts for improved readability and performance.
  • Adjusted Vite configuration to optimize dependency inclusion and removed unnecessary buffer alias.
  • Updated Vercel configuration to ensure correct API routing for blockscout services.
  • Excluded test files from TypeScript compilation in tsconfig.app.json.

Timidan added 3 commits April 15, 2026 17:06
- Consolidated button styles and removed unused classes from SimulationResultsPage.css.
- Deleted SimulatorWorkbench.css as its styles are now integrated into other CSS files.
- Removed redundant styles from StackedOverview.css, TokenMovementsPanel.css, and design-tokens.css.
- Updated type definitions in contractInfo.ts, debug.ts, and transaction.ts by removing unused types.
- Refactored utility functions in diamondFacetFetcher.ts, resultFormatter.ts, traceDecoder modules, and universalTokenDetector.ts for improved readability and performance.
- Adjusted Vite configuration to optimize dependency inclusion and removed unnecessary buffer alias.
- Updated Vercel configuration to ensure correct API routing for blockscout services.
- Excluded test files from TypeScript compilation in tsconfig.app.json.
Copilot AI review requested due to automatic review settings May 6, 2026 14:19
@vercel
Copy link
Copy Markdown

vercel Bot commented May 6, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
web3-toolkit Ready Ready Preview, Comment May 6, 2026 2:19pm

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f97c948b37

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 336 to 339
if (!raw) {
// Try migrating from old settings
const migrated = migrateFromOldSettings();
if (migrated) return migrated;
// Even with no config blob, persisted secrets may exist
const secrets = readSecrets();
return {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Restore legacy RPC settings migration

For users upgrading from a version that only has the old web3-toolkit:user-rpc-settings or web3-toolkit-universal-api-keys localStorage entries, this path now returns defaults plus any already-split secrets and never reads those legacy keys. That drops custom RPC mode/URLs and explorer API keys for direct upgraders, so the old migration should remain until those storage keys are no longer expected in the wild.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR focuses on reducing legacy surface area (CSS + unused TS types), consolidating shared utilities/constants, and aligning build/runtime configuration with the current proxy routing approach (notably Blockscout + EDB).

Changes:

  • Updated Vercel rewrites to add explicit /api/edb routing to edb-proxy and to route Blockscout proxies to upstream /api/* endpoints.
  • Simplified Vite dependency optimization/aliasing (dropping the buffer optimize/alias) and excluded test files from the app TS build.
  • Refactored/shared utilities and types (e.g., ZERO_ADDRESS, ensureArray, resolver source types), plus minor readability refactors (letconst) across several utility modules.

Reviewed changes

Copilot reviewed 128 out of 131 changed files in this pull request and generated no comments.

Show a summary per file
File Description
vite.config.ts Removes buffer from optimizeDeps and drops the buffer alias; simplifies manual chunking.
vercel.json Adds /api/edb/api/edb-proxy rewrites and updates Blockscout rewrite destinations to include /api/:path*.
tsconfig.app.json Excludes test/spec files from TypeScript compilation for the app build.
src/utils/universalTokenDetector.ts Minor refactor (letconst) for default fallback values in detection flow.
src/utils/transaction-simulation/bridgeSimulation.ts Minor refactor (letconst) for a libraries map object.
src/utils/traceDecoder/pcMapper.ts Minor refactor (letconst) for a default tuple used during mapping.
src/utils/traceDecoder/jumpAnalysis.ts Comment formatting + minor refactor (letconst) for promoted source file.
src/utils/traceDecoder/decodeTraceInit.ts Minor refactor (letconst) for raw text capture.
src/utils/traceDecoder/callHierarchy.ts Comment formatting cleanup.
src/utils/traceDecoder/analysisHelpers.ts Comment formatting cleanup.
src/utils/solidity-layout/allocatorTypeHelpers.ts Comment formatting cleanup.
src/utils/simulationArtifactTypes.ts Introduces shared ensureArray helper alongside simulation artifact types.
src/utils/simulationArtifacts.ts Re-exports/imports ensureArray from simulationArtifactTypes to centralize the helper.
src/utils/resultFormatter.ts Minor refactor (letconst) for local formatting array.
src/utils/resolver/types.ts Removes unsupported resolver sources from the Source union and config map.
src/utils/resolver/proxyResolver.ts Uses shared ZERO_ADDRESS constant instead of a local literal.
src/utils/resolver/ContractResolver.ts Removes unimplemented source cases (blockscout-ebd, whatsabi) from the switch.
src/utils/resolver/contractContext.ts Uses shared ZERO_ADDRESS constant instead of a local literal.
src/utils/edbTraceConverter.ts Switches ensureArray import to simulationArtifactTypes after extraction.
src/utils/diamondFacetFetcher.ts Adjusts Blockscout URL construction to match new proxy rewrite behavior (no local /api prefix).
src/utils/cache/sourcifyCache.ts Removes outdated reference to a legacy fetcher in documentation comments.
src/utils/addressConstants.ts Adds shared address constants and isNativeToken helper.
src/types/transaction.ts Removes unused AssetChange type definition.
src/types/index.ts Refactors types barrel to re-export from chain/abi modules.
src/types/debug.ts Removes unused RpcCapabilities type.
src/types/contractInfo.ts Updates Chain import path and removes unused exported helper types.
src/types/chain.ts Introduces a dedicated module for Chain and explorer-related types.
src/types/abi.ts Defines ABIFetchResult locally (instead of importing via the barrel) and keeps ABI-related types grouped.
src/styles/TokenMovementsPanel.css Removes unused CSS classes for token id and empty state styling.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants