fix: advertise mcp scope in OAuth metadata#10
Conversation
Co-authored-by: Codex <codex@openai.com>
|
Working on this PR… |
There was a problem hiding this comment.
Summary
Adds mcp to the OAuth provider's supported scopes so the authorization server metadata matches the MCP protected-resource challenge. The change is a single-line scope addition plus a corresponding test assertion. No issues found — the change is correct, consistent with existing MCP auth plumbing, and the test matcher (arrayContaining) is appropriate. Safe to merge.
Mergeability Score: 5/5
Safe to merge from this review's perspective.
There was a problem hiding this comment.
Summary
Security review: no exploitable vulnerabilities found. This PR adds mcp to the OAuth provider's advertised scopes, aligning the authorization server metadata with the protected resource metadata that already required the mcp scope. The change is a configuration-only metadata fix in lib/auth.ts; no authentication, authorization, or input validation logic is modified. The JWT verification path in lib/mcp/auth.ts is unchanged. Safe to merge.
Mergeability Score: 5/5
Safe to merge from this review's perspective.
Summary
Advertise the mcp scope in the OAuth authorization server metadata so Claude Web and other OAuth MCP clients see metadata that matches the MCP protected-resource challenge.
What's Included
Tests
Test Plan
Local Review Findings