Open
Conversation
TimothyEDawson
force-pushed
the
python-type-stubs-testing
branch
3 times, most recently
from
174d595 to
38f744c
Compare
Only raise deprecation warnings if npos or -1 is expected, and the new 'raise' argument is needed.
Prevents future changes in the CLib code despite changes in the C++ API.
TimothyEDawson
force-pushed
the
python-type-stubs-testing
branch
3 times, most recently
from
66acf4a to
dd56f17
Compare
Adding stubs alongside the Python files to provide type hints for external use. These are intended to cover the public interface, including all dynamically-generated attributes.
Moved literal_type_guard to a new _types.py file and added a new function add_args_to_signature. Made several minor typing improvements in the course of updating yaml2ck.py.
Only numpy.typing.ArrayLike needs to be explicitly exported, which can be achieved with the `from X import Y as Y` syntax.
TODO: Update add_args_to_signature to support TypeForm[T] instead of only type[T] so it can properly accept e.g. Iterable[str].
Includes an initial whitelist to make stubtest pass located at interfaces/cython/.mypyignore, which should be reduced to the minimal set of items which cannot be correctly inferred at runtime (e.g. __cinit__ signatures).
TimothyEDawson
force-pushed
the
python-type-stubs-testing
branch
from
dd56f17 to
1901684
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request for testing CI changes.