fix: wrong args for execute child workflow!

[amindadgar]

Summary by CodeRabbit

• Chores
  • Updated workflow timeout settings to adjust allowed runtimes for extract, transform, and load steps.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The update modifies how timeouts are set in the MediaWikiETLWorkflow.run method by replacing the start_to_close_timeout parameter with execution_timeout in all child workflow executions. Additionally, the timeout durations for extract and load child workflows are increased, while the transform workflow timeout remains unchanged.

Changes

File(s)	Change Summary
hivemind_etl/mediawiki/workflows.py	Replaced start_to_close_timeout with execution_timeout in child workflow calls; updated timeout durations for extract (5d→6d) and load (3h→3d) steps, transform remains at 6h.

Sequence Diagram(s)

sequenceDiagram
    participant ParentWorkflow as MediaWikiETLWorkflow
    participant ExtractChild as ExtractWorkflow
    participant TransformChild as TransformWorkflow
    participant LoadChild as LoadWorkflow

    ParentWorkflow->>ExtractChild: execute_child_workflow(execution_timeout=6d)
    ExtractChild-->>ParentWorkflow: result
    ParentWorkflow->>TransformChild: execute_child_workflow(execution_timeout=6h)
    TransformChild-->>ParentWorkflow: result
    ParentWorkflow->>LoadChild: execute_child_workflow(execution_timeout=3d)
    LoadChild-->>ParentWorkflow: result

Loading

Possibly related PRs

• feat: converted mediawiki activities to workflows! #54: Updates child workflow execution calls in MediaWikiETLWorkflow.run, matching the parameter and timeout changes in this PR.
• fix: increase timeouts for mediawiki data processing activities #42: Adjusts timeout durations and retry intervals for activities, which is related as both PRs modify timeout handling in workflow execution.

Poem

The clock ticks on, the timeouts grow,
Six days to extract, let data flow!
Transform holds steady, steadfast and bright,
Load now has days, not just a night.
With new parameters, our workflows run true,
🕰️🐇 ETL magic, all thanks to you!

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c3aad42 and 1700ee9.

📒 Files selected for processing (1)

• hivemind_etl/mediawiki/workflows.py (2 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.