Skip to content

fix(dht): Suppress the warning about IPv6 nodes when IPv6 is turned off#3032

Merged
Green-Sky merged 1 commit into
TokTok:masterfrom
nickolay168:nickolay168/fix_ipv6_warnings
May 7, 2026
Merged

fix(dht): Suppress the warning about IPv6 nodes when IPv6 is turned off#3032
Green-Sky merged 1 commit into
TokTok:masterfrom
nickolay168:nickolay168/fix_ipv6_warnings

Conversation

@nickolay168
Copy link
Copy Markdown

@nickolay168 nickolay168 commented Apr 26, 2026

If user switches off IPv6 and initiates tox, the requests to to the IPv6 bootstrap nodes is still done, which results in a lot of warning messages in the log.

In this PR we check if this is the case before calling net_send_packet, hence avoiding the warning.
Related to #1432


This change is Reviewable

@github-actions github-actions Bot added the bug Bug fix for the user, not a fix to a build script label Apr 26, 2026
@nickolay168 nickolay168 force-pushed the nickolay168/fix_ipv6_warnings branch 3 times, most recently from a186377 to 912d62a Compare April 26, 2026 04:25
@nickolay168 nickolay168 marked this pull request as ready for review April 26, 2026 04:50
@nickolay168 nickolay168 force-pushed the nickolay168/fix_ipv6_warnings branch from 912d62a to f13325b Compare April 26, 2026 04:55
@nickolay168 nickolay168 changed the title fix(dht): Suooress the warning about IPv6 nodes when IPv6 is turned off fix(dht): Suppress the warning about IPv6 nodes when IPv6 is turned off Apr 26, 2026
Comment thread toxcore/network.c Outdated
@nickolay168 nickolay168 force-pushed the nickolay168/fix_ipv6_warnings branch from f13325b to 186843e Compare April 26, 2026 22:59
Comment thread toxcore/network.c Outdated
Comment thread toxcore/onion.c Outdated
Comment thread toxcore/network.h
@nickolay168 nickolay168 force-pushed the nickolay168/fix_ipv6_warnings branch 5 times, most recently from 616131d to 74bcc23 Compare April 29, 2026 07:03
@nickolay168 nickolay168 requested a review from Green-Sky April 29, 2026 07:25
@nickolay168 nickolay168 force-pushed the nickolay168/fix_ipv6_warnings branch from 74bcc23 to 161aecb Compare May 1, 2026 07:03
@nickolay168
Copy link
Copy Markdown
Author

It seems all non-bazel related tests are passing. @Green-Sky, could you please take another look?

Copy link
Copy Markdown
Member

@Green-Sky Green-Sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ready otherwise.

Comment thread toxcore/network.h Outdated
@nickolay168 nickolay168 force-pushed the nickolay168/fix_ipv6_warnings branch 2 times, most recently from 34479a0 to b726b93 Compare May 6, 2026 03:28
@Green-Sky Green-Sky force-pushed the nickolay168/fix_ipv6_warnings branch from b726b93 to b580aca Compare May 7, 2026 09:02
@Green-Sky Green-Sky force-pushed the nickolay168/fix_ipv6_warnings branch from b580aca to 71c354b Compare May 7, 2026 09:02
@Green-Sky Green-Sky added this to the v0.2.23 milestone May 7, 2026
@Green-Sky Green-Sky merged commit 71c354b into TokTok:master May 7, 2026
100 of 109 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Bug fix for the user, not a fix to a build script

Development

Successfully merging this pull request may close these issues.

2 participants