Indicate nodes not supported by current event + node folders#1156
Open
Lwmte wants to merge 15 commits into
Open
Indicate nodes not supported by current event + node folders#1156Lwmte wants to merge 15 commits into
Lwmte wants to merge 15 commits into
Conversation
Lwmte
added
enhancement
Nickelony
previously approved these changes
Mar 22, 2026
Collaborator
Nickelony
left a comment
Nickelony
left a comment
There was a problem hiding this comment.
Looks good! I'll poke Copilot as well to review just in case.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds metadata-driven support/unsupported event type tagging for visual scripting nodes, and surfaces a UI warning when a node is used under an incompatible event type.
Changes:
- Parse new
!Supported/!Unsupportedmetadata tags intoNodeFunctiondefinitions. - Add support checks (
IsUnsupported) toNodeFunctionand propagate current event type into the node editor UI. - Document the new metadata tags in the TEN node catalog Readme.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| TombLib/TombLib/Utils/ScriptingUtils.cs | Parses !Supported / !Unsupported tags into event type lists. |
| TombLib/TombLib/LevelData/VisualScripting/TriggerNodeEnumerations.cs | Stores per-node supported/unsupported event lists and exposes IsUnsupported. |
| TombLib/TombLib/Catalogs/TEN Node Catalogs/Readme.md | Documents the new metadata tag syntax and available event types. |
| TombLib/TombLib.Forms/Controls/VisualScripting/NodeEditor.cs | Displays a warning indicator/message when a node is incompatible with the current event type. |
| TombEditor/Forms/FormEventSetEditor.cs | Propagates event type changes into TriggerManager. |
| TombEditor/Controls/TriggerManager.cs | Exposes EventType and forwards it to the embedded node editor. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Lwmte
changed the title
TrainWrack
approved these changes
Apr 11, 2026
Collaborator
TrainWrack
left a comment
TrainWrack
left a comment
There was a problem hiding this comment.
Tested multi level folders. They saved and reloaded ok.
Tested nodes event support. Worked as described.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 14 out of 15 changed files in this pull request and generated 4 comments.
Files not reviewed (1)
- TombEditor/Forms/FormEventSetEditor.Designer.cs: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an indication that a node is not supported by the current event type:
To define whether node is supported or not supported by a particular event type, define new metadata entries:
-- !Unsupported "OnLoop" "OnLevelStart"-- !Supported "OnVolumeEnter"Additionally, adds support for folders in the node list.