Fix numerous TE memory issues

DarkUI/DarkUI/Collections/ObservableList.cs

@@ -19,28 +19,13 @@ public class ObservableList<T> : List<T>, IDisposable
 
         #endregion
 
-        #region Destructor Region
-
-        ~ObservableList()
-        {
-            Dispose(false);
-        }
-
-        #endregion
-
         #region Dispose Region
 
-        public void Dispose()
-        {
-            Dispose(true);
-            GC.SuppressFinalize(this);
-        }
-
-        protected virtual void Dispose(bool disposing)
+        public virtual void Dispose()
         {
             if (_disposed)
                 return;
-            
+
             ItemsAdded = null;
             ItemsRemoved = null;
 

TombEditor/Controls/ImportedGeometryManager.cs

@@ -139,6 +139,7 @@ public void Set(SetValue setValue)
 
         private readonly Color _correctColor;
         private readonly Color _wrongColor;
+        private ListChangedEventHandler _listChangedHandler;
 
         public ImportedGeometryManager()
         {
@@ -193,7 +194,7 @@ public ImportedGeometryManager()
             };
             dataGridView.DataSource = _dataGridViewDataSource;
             dataGridViewControls.DeleteRowCheckIfCancel = MessageUserAboutHimDeletingRows;
-            _dataGridViewDataSource.ListChanged += delegate (object sender, ListChangedEventArgs e)
+            _listChangedHandler = delegate (object sender, ListChangedEventArgs e)
                 {
                     switch (e.ListChangedType)
                     {
@@ -203,6 +204,7 @@ public ImportedGeometryManager()
                             break;
                     }
                 };
+            _dataGridViewDataSource.ListChanged += _listChangedHandler;
 
             Enabled = true;
 
@@ -214,8 +216,11 @@ protected override void Dispose(bool disposing)
         {
             if (disposing)
             {
+                _dataGridViewDataSource.ListChanged -= _listChangedHandler;
                 components?.Dispose();
-                Editor.Instance.EditorEventRaised -= EditorEventRaised;
+
+                if (Editor.Instance is not null)
+                    Editor.Instance.EditorEventRaised -= EditorEventRaised;
             }
 
             base.Dispose(disposing);

TombEditor/Controls/Panel3D/Panel3D.cs

@@ -140,6 +140,8 @@ public bool DisablePickingForHiddenRooms
         private Buffer<SolidVertex> _objectHeightLineVertexBuffer;
         private Buffer<SolidVertex> _flybyPathVertexBuffer;
         private Buffer<SolidVertex> _ghostBlockVertexBuffer;
+        private SolidVertex[] _ghostBlockVertices = new SolidVertex[84];
+        private float[] _roomsDistanceCache;
         private Buffer<SolidVertex> _boxVertexBuffer;
 
         // Flyby stuff
@@ -243,6 +245,7 @@ protected override void Dispose(bool disposing)
                 _rasterizerStateDepthBias?.Dispose();
                 _currentContextMenu?.Dispose();
                 _wadRenderer?.Dispose();
+                _fontDefault?.Dispose();
             }
             base.Dispose(disposing);
         }
@@ -397,6 +400,7 @@ obj is Editor.HideSelectionEvent ||
             // Stop camera animation if level is changing
             if (obj is Editor.LevelChangedEvent)
             {
+                _roomsDistanceCache = null;
                 _movementTimer.Stop(true);
 
                 if (_editor.CameraPreviewMode != CameraPreviewType.None)

TombEditor/Controls/Panel3D/Panel3DDraw.cs

@@ -713,8 +713,9 @@ private void DrawGhostBlockBodies(Effect effect, List<GhostBlockInstance> ghostB
                 if (!instance.Valid)
                     continue;
 
-                // Create a vertex array
-                SolidVertex[] vtxs = new SolidVertex[84]; // 78 with diagonal steps
+                // Reuse cached vertex array
+                SolidVertex[] vtxs = _ghostBlockVertices;
+                Array.Clear(vtxs, 0, vtxs.Length);
 
                 // Derive base sector colours
                 var p1c = new Vector4(baseColor.To3() * (selected ? 0.8f : 0.4f), selected ? 0.7f : 0.5f);

TombEditor/Controls/Panel3D/Panel3DDrawCollector.cs

@@ -144,12 +144,14 @@ Room[] CollectRoomsToDraw()
             // Collect rooms to draw
             var camPos = Camera.GetPosition();
             var roomsToDraw = CollectRoomsToDraw(_editor.SelectedRoom).ToArray();
-            var roomsToDrawDistanceSquared = new float[roomsToDraw.Length];
+
+            if (_roomsDistanceCache == null || _roomsDistanceCache.Length < roomsToDraw.Length)
+                _roomsDistanceCache = new float[roomsToDraw.Length];
 
             for (int i = 0; i < roomsToDraw.Length; ++i)
-                roomsToDrawDistanceSquared[i] = Vector3.DistanceSquared(camPos, roomsToDraw[i].WorldPos + roomsToDraw[i].GetLocalCenter());
+                _roomsDistanceCache[i] = Vector3.DistanceSquared(camPos, roomsToDraw[i].WorldPos + roomsToDraw[i].GetLocalCenter());
 
-            Array.Sort(roomsToDrawDistanceSquared, roomsToDraw);
+            Array.Sort(_roomsDistanceCache, roomsToDraw, 0, roomsToDraw.Length);
             Array.Reverse(roomsToDraw);
 
             return roomsToDraw;

TombLib/TombLib.Rendering/Rendering/RenderingFont.cs

@@ -315,23 +315,30 @@ public class GlyphRenderInfo
 
         public void Dispose()
         {
-            if (!_disposed)
+            if (_disposed)
                 return;
             _disposed = true;
 
             TextureAllocator?.Dispose();
+            ReleaseUnmanagedResources();
+
+            GC.SuppressFinalize(this);
+        }
+
+        ~RenderingFont()
+        {
+            ReleaseUnmanagedResources();
+        }
+
+        private void ReleaseUnmanagedResources()
+        {
             GDI.DeleteObject(_gdiFont);
             GDI.DeleteDC(_gdiHdc);
             Marshal.FreeHGlobal(_gdiGetCharacterPlacementOrder);
             Marshal.FreeHGlobal(_gdiGetCharacterPlacementDx);
             Marshal.FreeHGlobal(_gdiGetCharacterPlacementGlpyhs);
         }
 
-        ~RenderingFont()
-        {
-            Dispose();
-        }
-
         private static class GDI
         {
             public class GDIException : Exception

TombLib/TombLib/IO/BinaryWriterFast.cs

@@ -52,6 +52,8 @@ public void Dispose()
             _ptr = null;
             _startPtr = null;
             _baseStream = null;
+
+            GC.SuppressFinalize(this);
         }
 
         public Stream BaseStream

TombLib/TombLib/LevelData/ImportedGeometry.cs

@@ -16,10 +16,12 @@
 
 namespace TombLib.LevelData
 {
-    public class ImportedGeometryTexture : Texture
+    public class ImportedGeometryTexture : Texture, IDisposable
     {
         public Texture2D DirectXTexture { get; private set; }
 
+        private bool _disposed;
+
         public ImportedGeometryTexture(string absolutePath)
         {
             AbsolutePath = absolutePath;
@@ -31,22 +33,39 @@ public ImportedGeometryTexture(string absolutePath)
             if (SynchronizationContext.Current == null)
                 DirectXTexture = TextureLoad.Load(ImportedGeometry.Device, Image);
             else
-                SynchronizationContext.Current.Post(unused => // Synchronize DirectX, we can't 'send' because that may deadlock with the level settings reloader
-                DirectXTexture = TextureLoad.Load(ImportedGeometry.Device, Image), null);
+                SynchronizationContext.Current.Post(unused => {
+                    if (_disposed)
+                        return;
+
+                    DirectXTexture = TextureLoad.Load(ImportedGeometry.Device, Image);
+                }, null);
         }
 
         private ImportedGeometryTexture(ImportedGeometryTexture other)
         {
-            DirectXTexture = other.DirectXTexture;
             AbsolutePath = other.AbsolutePath;
             Image = other.Image;
         }
 
         public void Assign(ImportedGeometryTexture other)
         {
+            // Dispose old GPU texture if it differs from the new one.
+            if (DirectXTexture != null && DirectXTexture != other.DirectXTexture)
+                DirectXTexture.Dispose();
+
             AbsolutePath = other.AbsolutePath;
             Image = other.Image;
             DirectXTexture = other.DirectXTexture;
+
+            _disposed = false;
+        }
+
+        public void Dispose()
+        {
+            _disposed = true;
+
+            DirectXTexture?.Dispose();
+            DirectXTexture = null;
         }
 
         public override Texture Clone() => new ImportedGeometryTexture(this);

TombLib/TombLib/Wad/WadTexture.cs

@@ -1,7 +1,9 @@
 using System;
+using System.Buffers.Binary;
 using System.IO;
 using TombLib.Graphics;
 using TombLib.Utils;
+using Blake3Hasher = Blake3.Hasher;
 
 namespace TombLib.Wad
 {
@@ -20,14 +22,20 @@ public WadTexture(ImageC image)
         {
             Image = image;
 
-            using (var ms = new MemoryStream())
-            {
-                var writer = new BinaryWriter(ms);
-                writer.Write(Image.Size.X);
-                writer.Write(Image.Size.Y);
-                Image.WriteToStreamRaw(ms);
-                Hash = Hash.FromByteArray(ms.ToArray());
-            }
+            // Hash image dimensions and pixel data directly without intermediate copies.
+            using var hasher = Blake3Hasher.New();
+            Span<byte> header = stackalloc byte[8];
+            BinaryPrimitives.WriteInt32LittleEndian(header, Image.Size.X);
+            BinaryPrimitives.WriteInt32LittleEndian(header.Slice(4), Image.Size.Y);
+            hasher.Update(header);
+            hasher.Update(Image.ToByteArray());
+
+            Span<byte> digest = stackalloc byte[32];
+            hasher.Finalize(digest);
+
+            ulong low = BinaryPrimitives.ReadUInt64LittleEndian(digest.Slice(0, 8));
+            ulong high = BinaryPrimitives.ReadUInt64LittleEndian(digest.Slice(8, 8));
+            Hash = new Hash { HashLow = low, HashHigh = high };
         }
 
         public override Texture Clone() => this;

WadTool/Controls/PanelRenderingAnimationEditor.cs

@@ -141,7 +141,6 @@ protected override void Dispose(bool disposing)
         {
             if (disposing)
             {
-                _fontTexture?.Dispose();
                 _fontDefault?.Dispose();
                 _gizmo?.Dispose();
                 _plane?.Dispose();

WadTool/Controls/PanelRenderingMesh.cs

@@ -353,6 +353,7 @@ protected override void Dispose(bool disposing)
                 _bigSphere?.Dispose();
                 _plane?.Dispose();
                 _wadRenderer?.Dispose();
+                _fontDefault?.Dispose();
             }
             base.Dispose(disposing);
         }

WadTool/Controls/PanelRenderingSkeleton.cs

@@ -114,7 +114,6 @@ protected override void Dispose(bool disposing)
         {
             if (disposing)
             {
-                _fontTexture?.Dispose();
                 _fontDefault?.Dispose();
                 _rasterizerWireframe?.Dispose();
                 _vertexBufferVisibility?.Dispose();

WadTool/Controls/PanelRenderingStaticEditor.cs

@@ -139,7 +139,6 @@ protected override void Dispose(bool disposing)
         {
             if (disposing)
             {
-                _fontTexture?.Dispose();
                 _fontDefault?.Dispose();
                 _gizmo?.Dispose();
                 _gizmoLight?.Dispose();