Ring inventory#1189
Open
TrainWrack wants to merge 8 commits into
Open
Conversation
This reverts commit cc5d701.
Add slot for sprites
2 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
Adds TombEngine visual-scripting node catalog entries for triggering the ring-inventory statistics screen, and extends the TombEngine sprite sequence catalog with a dedicated inventory sprite slot.
Changes:
- Added
ShowEndLevelStatistics/ShowEndGameStatisticsnodes (TEN node catalog) that invokeEngine.RingInventory.Statistics. - Added a new TombEngine sprite sequence entry:
INVENTORY_SPRITES(id1389).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| TombLib/TombLib/Catalogs/TEN Node Catalogs/Statistics.lua | New visual-scripting nodes to display end-of-level/end-of-game statistics and then transition the flow. |
| TombLib/TombLib/Catalogs/Engines/TombEngine/SpriteSequences.xml | Registers a new sprite sequence name/id for inventory-related sprites. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds nodes for Statistics
Adds sprite slot for ring inventory
Sprites
https://github.com/user-attachments/files/26648869/Sprites.zip
Requires
TombEngine/TombEngine#1976