Prevent UInt16 overflow when deleting WadTool state changes#1204
Open
Copilot wants to merge 4 commits into
Open
Prevent UInt16 overflow when deleting WadTool state changes#1204Copilot wants to merge 4 commits into
Copilot wants to merge 4 commits into
Conversation
Agent-Logs-Url: https://github.com/TombEngine/Tomb-Editor/sessions/b05fc5bc-fbda-44f0-a16d-90baf7609461 Co-authored-by: Nickelony <20436882+Nickelony@users.noreply.github.com>
Agent-Logs-Url: https://github.com/TombEngine/Tomb-Editor/sessions/b05fc5bc-fbda-44f0-a16d-90baf7609461 Co-authored-by: Nickelony <20436882+Nickelony@users.noreply.github.com>
Agent-Logs-Url: https://github.com/TombEngine/Tomb-Editor/sessions/b05fc5bc-fbda-44f0-a16d-90baf7609461 Co-authored-by: Nickelony <20436882+Nickelony@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix error message when trying to delete state changes
Prevent UInt16 overflow when deleting WadTool state changes
Apr 19, 2026
Collaborator
|
WinForms back at it again... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deleting the first row in WadTool's Animation Editor state change grid could throw a
System.OverflowExceptionfromDataGridViewwhile rebinding cell values. The failure was caused by unsigned row-bound properties receiving transient invalid values during grid row removal.Use signed editing state in the grid
FormStateChangesEditor'sWadStateChangeRownumeric fields fromushorttoint.DataGridViewediting/deletion in a signed domain and avoids the WinForms conversion path that overflowed on row deletion.Clamp only at persistence boundaries
WadStateChange/WadAnimDispatch.ushort-based; only the editor's in-memory row model changed.Keep related editor paths consistent