Skip empty sound sources during sound autodetection#1205
Open
Copilot wants to merge 2 commits into
Open
Conversation
Agent-Logs-Url: https://github.com/TombEngine/Tomb-Editor/sessions/7a6df68a-a02a-40b7-84a7-3f61a4c6e5c3 Co-authored-by: Nickelony <20436882+Nickelony@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix sound auto-detection adding entry for empty sound source
Skip empty sound sources during sound autodetection
Apr 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Autodetecting sounds from placed sound sources was treating unassigned sound sources as real sound IDs and adding the internal sentinel value
-1toSelectedSounds. This caused the sound list UI to surface a bogus-1entry when empty sound sources existed in the map.Behavior change
AssignSoundSourcesSoundsnow ignores emptySoundSourceInstances instead of copying their sentinel ID into level sound selection.Why this is the correct boundary
SoundSourceInstance.IsEmpty.-1as "no sound assigned", so autodetection now follows the same contract instead of leaking the sentinel into user-facing selection state.Scope