Restrict portal shade interpolation to actual portal-edge vertices#1210
Open
Copilot wants to merge 4 commits into
Open
Restrict portal shade interpolation to actual portal-edge vertices#1210Copilot wants to merge 4 commits into
Copilot wants to merge 4 commits into
Conversation
Agent-Logs-Url: https://github.com/TombEngine/Tomb-Editor/sessions/b1a5cc85-7551-4a1d-923d-6c0da8a27227 Co-authored-by: Nickelony <20436882+Nickelony@users.noreply.github.com>
Agent-Logs-Url: https://github.com/TombEngine/Tomb-Editor/sessions/b1a5cc85-7551-4a1d-923d-6c0da8a27227 Co-authored-by: Nickelony <20436882+Nickelony@users.noreply.github.com>
Agent-Logs-Url: https://github.com/TombEngine/Tomb-Editor/sessions/b1a5cc85-7551-4a1d-923d-6c0da8a27227 Co-authored-by: Nickelony <20436882+Nickelony@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix lighting issue for overlapping vertices
Restrict portal shade interpolation to actual portal-edge vertices
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vertices that share world coordinates across adjacent rooms could inherit lighting from the wrong room during shade matching. This showed up as bright/dark seams on non-portal geometry whenever coincident vertices happened to fall inside the portal match region.
### Root cause### ChangePortalShadeMatchHelperused by both room compilers.### Test coverageInternalsVisibleTo.