Skip to content

Fix for using bindings.js with eval #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pverscha wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix for using bindings.js with eval #66

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 44 additions & 6 deletions bindings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,28 @@ function bindings(opts) {

// Get the module root
if (!opts.module_root) {
opts.module_root = exports.getRoot(exports.getFileName());
const fileName = exports.getFileName();
let module_root = exports.getRoot(fileName);

// Filename is undefined when eval() was used to execute code with bindings in it. We don't have a valid
// module-root in that case and need to use a heuristic to hopefully find the correct directory.
if (!fileName) {
// Derive module_root from ".node"-filename
const possible_package_name = opts.bindings.replace('.node', '');
let best_score = -1;
let best_match = "";
for (const file of fs.readdirSync(join(module_root, 'node_modules'))) {
const current_score = compare(file, possible_package_name);
if (current_score > best_score) {
best_score = current_score;
best_match = file;
}
}

module_root = join(module_root, 'node_modules', best_match);
}

opts.module_root = module_root;
}

// Ensure the given bindings name ends with .node
Expand Down Expand Up @@ -115,11 +136,9 @@ function bindings(opts) {
}
return b;
} catch (e) {
if (
e.code !== 'MODULE_NOT_FOUND' &&
e.code !== 'QUALIFIED_PATH_RESOLUTION_FAILED' &&
!/not find/i.test(e.message)
) {
if (e.code !== 'MODULE_NOT_FOUND' &&
e.code !== 'QUALIFIED_PATH_RESOLUTION_FAILED' &&
!/not find/i.test(e.message)) {
throw e;
}
}
Expand All @@ -138,6 +157,21 @@ function bindings(opts) {
}
module.exports = exports = bindings;

/**
* Returns a similarity score for two strings.
* See: https://stackoverflow.com/questions/10473745/compare-strings-javascript-return-of-likely
*/
function compare(strA, strB){
for(var result = 0, i = strA.length; i--;){
if(typeof strB[i] == 'undefined' || strA[i] == strB[i]);
else if(strA[i].toLowerCase() == strB[i].toLowerCase())
result++;
else
result += 4;
}
return 1 - (result + 4*Math.abs(strA.length - strB.length))/(2*(strA.length+strB.length));
}

/**
* Gets the filename of the JavaScript file that invokes this function.
* Used to help find the root directory of a module.
Expand Down Expand Up @@ -175,6 +209,10 @@ exports.getFileName = function getFileName(calling_file) {
Error.prepareStackTrace = origPST;
Error.stackTraceLimit = origSTL;

if (!fileName) {
return "";
}

// handle filename that starts with "file://"
var fileSchema = 'file://';
if (fileName.indexOf(fileSchema) === 0) {
Expand Down