make flush argument optional to close function in typings#151
Open
MasterOdin wants to merge 1 commit intoTooTallNate:masterfrom
Open
make flush argument optional to close function in typings#151MasterOdin wants to merge 1 commit intoTooTallNate:masterfrom
MasterOdin wants to merge 1 commit intoTooTallNate:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The type doc for the
closemethod mentions that theflushargument defaults totrue. This leads one to believe that the parameter is optional, however, the actual definition makes the parameter mandatory within TypeScript. This PR fixes that so that the parameter is fully optional to use or not, which also aligns with suggested usage I've seen of the method elsewhere in issues and the like.