Don't panic if a write doesn't fully complete#170
Open
thenickdude wants to merge 1 commit intoTooTallNate:masterfrom
Open
Don't panic if a write doesn't fully complete#170thenickdude wants to merge 1 commit intoTooTallNate:masterfrom
thenickdude wants to merge 1 commit intoTooTallNate:masterfrom
Conversation
36b5513 to
5c421e8
Compare
|
I'd like to add to this because I'm having similar issues. I've tried the modified branch and it doesn't seem to fix the issue for me, is still get the following error I'm confused as to why it is needed to error. As a quick test I've modified the following 207c207
< done(new Error(`write() failed: ${r}`))
> done()and now my code works just fine without crashing the whole app, can't we just ignore length 0 or prevent it from getting to line 207 elsewhere? thx, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On my Raspberry Pi 3B+, after about 5-10 mins of piping different files to the speaker, I get an error like:
But it's perfectly reasonable for a write() to write fewer bytes than requested (e.g. if the audio device's buffer fills up), so this PR fixes the code so it doesn't panic in this situation and just retries the write of the remaining bytes.
Now my Pi plays flawlessly.