Fix/bugs#1
Merged
Merged
Conversation
added 2 commits
May 16, 2026 13:36
…e guard, version mismatch - BarrelGuiHandler: consume ALL non-PICKUP slot actions (THROW, CLONE, QUICK_MOVE, etc.) to prevent item manipulation; only PICKUP triggers button actions. Previously QUICK_MOVE was incorrectly allowed to trigger actions. - BarrelGuiHandler: move OPEN_GUIS.put before buildInventory to eliminate race condition where handleClick could fire before state was registered. - BarrelGuiHandler: log WARN when unknown item id falls back to stone instead of silently substituting. - GuiRegistry: skip and warn on unsupported GUI types (e.g. legacy 'dialog') instead of silently loading them as empty GUIs. - gradle.properties: sync fabric_version to 0.116.12+1.21.1 to match build.gradle.
… Menu
1. Fix rows not working
- GuiScreenHandler.onSlotClick: replaced definition.getRows()*9 with
GenericContainerScreenHandler.getRows()*9 — these must match the actual
inventory size, not the raw JSON value.
- GuiDefinition.getRows(): now always returns Math.clamp(rows,1,6) so
callers never get an out-of-range value.
2. Left / Right / Shift click support
- Added ClickType enum: ANY | LEFT | RIGHT | SHIFT
- Added click_type field to Button record (default: ANY)
- GuiScreenHandler passes mouseButton int to handleClick
- handleClick resolves isLeft/isRight/isShift from mouseButton +
SlotActionType, then matches against button's ClickType filter.
3. /guiapi reload and /guiapi help subcommands
- reload: delegates to server.reloadResources() — same pipeline as /reload
- help: prints all commands and button JSON field reference
- list: now also shows rows count alongside pages
4. Mod Menu integration
- build.gradle: modCompileOnly modmenu:11.0.3 via Modrinth maven
- GuiApiModMenuEntry: info screen showing loaded GUIs with rows/pages
- fabric.mod.json: modmenu entrypoint + suggests: modmenu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.