Fix/bugs#4
Merged
Merged
Conversation
added 2 commits
May 17, 2026 07:49
After toggle actions ran, the inventory was never refreshed — the player saw the initial item regardless of tag state. Fix: after toggle action chain completes (without a close/navigate action breaking it), reopen the same GUI page so buildInventory re-evaluates the tag and renders the correct item/name/lore.
…tcher Command dispatcher execution is async relative to inventory rebuild — tag @s add/remove was not guaranteed to be reflected by the time buildInventory re-evaluated player.getCommandTags(). Fix: flip the tag directly with player.addCommandTag()/removeCommandTag() synchronously, then skip the auto-generated default tag commands in the action chain, then reopen. Custom side-effect actions (non-tag commands, messages) still execute normally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.