Skip to content

issue-276 #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rpelmegov wants to merge 5 commits into
base: master
Choose a base branch
from
Open

issue-276 #331

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
55ab60b
Update export_src.sh
rpelmegov Dec 14, 2022
45fbc84
Update export_src.sh
rpelmegov Jan 13, 2023
f0bbbb9
issue-276 add bad path alarm
rpelmegov Jan 30, 2023
4b5ee64
Update export_src.sh
rpelmegov Feb 6, 2023
302530f
Update export_src.sh
rpelmegov Feb 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions scripts/export_src.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,4 +46,18 @@ done
find . -name ".git*" -print0 | xargs -0 rm -rf
zip -r -q ${SRC_FOLDER_NAME}.zip .

read_err_path() {
read -d $'\0' err_path
}
Copy link
Copy Markdown
Contributor

@petropavel13 petropavel13 Feb 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

а нам точно нужна отдельная функция? можем этот код перенести к while?

Copy link
Copy Markdown
Author

@rpelmegov rpelmegov Feb 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Вынесено в функцию, чтобы дублирования не было


find . -name "*[<>:\\|?*]*" -print0 |
Copy link
Copy Markdown
Contributor

@petropavel13 petropavel13 Feb 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

вот тут я сломался. что тут происходит, куда уходит результат?

Copy link
Copy Markdown
Author

@rpelmegov rpelmegov Feb 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Результат читается построчно в функции read_err_path

Copy link
Copy Markdown
Contributor

@petropavel13 petropavel13 Feb 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

не ну это жесть какая-то. ищем в одной строчке, читаем в функции, а используем вообще дальше
давай попытаемся сделать как в нормальных языках программирования: переменные, зона видимости и вот это всё

if read_err_path; then
echo "Export aborted! Invalid characters found in file or directories name(s):\n- $err_path"
while read_err_path
do
echo "- $err_path"
done
exit
Copy link
Copy Markdown
Contributor

@petropavel13 petropavel13 Feb 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exit без кода что вернёт?

Copy link
Copy Markdown
Author

@rpelmegov rpelmegov Feb 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Вроде бы то же, что exit 0

Copy link
Copy Markdown
Author

@rpelmegov rpelmegov Feb 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Можно exit 1 написать, раз завершение с ошибкой, но разница будет ли

fi

open .