Skip to content

Dummy streams should be pending, not empty#2154

Merged
palfrey merged 2 commits intoTraceMachina:mainfrom
palfrey:default_pending_stream_for_redis
Feb 14, 2026
Merged

Dummy streams should be pending, not empty#2154
palfrey merged 2 commits intoTraceMachina:mainfrom
palfrey:default_pending_stream_for_redis

Conversation

@palfrey
Copy link
Member

@palfrey palfrey commented Feb 13, 2026

Description

#2076 has some dummy streams both for the unused case for subscriber_channel (only used by Redis clusters) and for the MockPubSub in tests. Both of the dummy streams were empty i.e. they continually return a None which is bad because the rest of the code assumes None means "the other end disconnected, so error out". This results in a lot of

{"timestamp":"2026-02-13T17:31:23.617211Z","level":"ERROR","fields":{"message":"Error receiving message in RedisSubscriptionManager from subscriber_channel"},"target":"nativelink_store::redis_store","span":{"name":"redis_subscribe_spawn"},"spans":[{"name":"redis_subscribe_spawn"}]}

This PR makes both dummy streams pending ones i.e. they just sit there and output nothing, which is what we actually want.

Type of change

Please delete options that aren't relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

bazel test //...

Checklist

  • Updated documentation if needed
  • Tests added/amended
  • bazel test //... passes locally
  • PR is contained in a single commit, using git amend see some docs

This change is Reviewable

@palfrey palfrey force-pushed the default_pending_stream_for_redis branch from 3f27d2a to 88e775b Compare February 13, 2026 23:46
@palfrey palfrey enabled auto-merge (squash) February 13, 2026 23:46
@palfrey palfrey merged commit e72b5a0 into TraceMachina:main Feb 14, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants