Feat/copilot mentions translations

[agualdron]

Summary

Localizes the Copilot mention menu and mention search flow across the apps/tradinggoose workspace. This centralizes mention copy, replaces display-string-based mention option keys with stable internal ids, makes submenu and aggregated search match localized labels and fallback names, and reloads block/workflow-block mention sources when the locale changes. It also adds focused Vitest coverage for localized rendering, filtering, and keyboard selection behavior.

Why

Non-English locales could still show hardcoded English mention labels and empty states, localized queries did not reliably match mention items, and block-based mention labels could become stale after switching locale. This change makes mention discovery and selection behave consistently in translated workspaces.

Type of Changes

• Bug fix
• New feature
• Breaking change
• Documentation
• Other: i18n copy updates and targeted test coverage

Affected Areas

• apps/tradinggoose
• apps/docs
• packages/*
• Workflows / execution
• Realtime / sockets
• Market data / charting
• Dev tooling / CI / infra
• Documentation only
• Other: Copilot mention menu / localization

Validation

bunx biome check apps/tradinggoose/widgets/widgets/copilot/components/user-input/components/mention-menu.tsx apps/tradinggoose/widgets/widgets/copilot/components/user-input/hooks/use-user-input-mention-sources.ts apps/tradinggoose/widgets/widgets/copilot/components/user-input/hooks/use-user-input-mentions.ts apps/tradinggoose/widgets/widgets/copilot/components/user-input/mention-copy.ts apps/tradinggoose/widgets/widgets/copilot/components/user-input/mention-utils.ts apps/tradinggoose/widgets/widgets/copilot/components/user-input/types.ts apps/tradinggoose/widgets/widgets/copilot/components/user-input/workspace-entity-mentions.ts apps/tradinggoose/widgets/widgets/copilot/workspace-entities.ts apps/tradinggoose/i18n/messages/en.json apps/tradinggoose/i18n/messages/es.json apps/tradinggoose/i18n/messages/zh.json apps/tradinggoose/widgets/widgets/copilot/components/user-input/mention-utils.test.ts apps/tradinggoose/widgets/widgets/copilot/components/user-input/components/mention-menu.test.tsx apps/tradinggoose/widgets/widgets/copilot/components/user-input/hooks/use-user-input-mention-sources.test.tsx apps/tradinggoose/widgets/widgets/copilot/components/user-input/hooks/use-user-input-mentions.test.tsx
# passed: Checked 15 files in 104ms. No fixes applied.

bun run test -- ./widgets/widgets/copilot/components/user-input/mention-utils.test.ts ./widgets/widgets/copilot/components/user-input/components/mention-menu.test.tsx ./widgets/widgets/copilot/components/user-input/hooks/use-user-input-mention-sources.test.tsx ./widgets/widgets/copilot/components/user-input/hooks/use-user-input-mentions.test.tsx
# run from apps/tradinggoose
# passed: 4 files, 21 tests

Reviewer Focus

• Verify localized mention labels, submenu titles, empty states, and inserted mention labels in non-English locales.
• Verify aggregated and submenu search with localized text, accent-insensitive Spanish queries, and localized log trigger labels.
• Verify locale-switch behavior for block and workflow-block mention sources while the mention menu remains open.

Risk / Rollout Notes

Low risk and scoped to client-side Copilot mention UX plus locale message files. The main regression surface is mention filtering and selection when switching locales mid-session; no backend, schema, or rollout changes are required.

Config / Data Changes

• Env vars added or changed: None
• Database schema or migration impact: None
• External services or provider behavior changed: None

Screenshots / Video

Not included in this draft.

Checklist

• I kept the change focused and reviewed my own diff
• I validated the change locally and documented the results above
• I updated docs, examples, or copy if behavior/user-facing flows changed
• I called out any env, schema, provider, or rollout impact
• I did not include secrets, tokens, or private credentials in this PR

[greptile-apps]

Greptile Summary

This PR localizes the Copilot mention menu end-to-end: it introduces a new mention-copy.ts module that derives all labels, empty states, and fallback strings from the next-intl message bundle, replaces every hardcoded English string in the menu and its filter utilities, and switches the MentionOption/MentionSubmenu types from display strings to stable internal IDs. It also adds NFD accent-stripping to the normalize helper and reloads block and workflow-block mention sources when the locale changes.

• mention-copy.ts (new): centralises all mention-menu copy behind typed accessor functions keyed on stable internal IDs; useCopilotMentionCopy surfaces the localized bundle to both the menu and the mentions hook.
• use-user-input-mention-sources.ts: adds locale-aware loading with ref-based stale-load cancellation for both blocks and workflow_blocks; workflow_blocks is missing a locale-based cleanup that can leave isLoadingWorkflowBlocks stuck after a mid-fetch locale switch.
• use-user-input-mentions.ts: adds a locale-change effect that calls ensureSubmenuLoaded(openSubmenuFor) when a submenu is open, ensuring items are refreshed without closing the menu.

Confidence Score: 3/5

Safe to merge for most scenarios; the workflow_blocks submenu can display a permanent loading spinner after a locale change that races an in-flight fetch.

The core localization work is well-structured. The missing useEffect([locale]) cleanup for isLoadingWorkflowBlocks means the workflow_blocks submenu can get stuck on Loading after a mid-fetch locale switch. A test assertion also appears to describe behaviour the implementation does not yet provide.

use-user-input-mention-sources.ts (missing locale-based isLoadingWorkflowBlocks reset) and use-user-input-mentions.test.tsx (suspect assertion on root-menu locale-change case)

Important Files Changed

Filename	Overview
apps/tradinggoose/widgets/widgets/copilot/components/user-input/hooks/use-user-input-mention-sources.ts	Adds locale-aware block/workflow-block loading with ref-based stale-load cancellation; a missing useEffect([locale]) cleanup for isLoadingWorkflowBlocks can leave the loading spinner stuck after a mid-fetch locale switch.
apps/tradinggoose/widgets/widgets/copilot/components/user-input/mention-copy.ts	New module centralising all mention-menu copy; extracts labels, submenu titles, empty states, and fallback strings from next-intl messages. Logic is clean and correctly uses per-entity fallback labels.
apps/tradinggoose/widgets/widgets/copilot/components/user-input/mention-utils.ts	Replaces display-string option keys with stable internal IDs, adds NFD accent-stripping to normalize, and threads copy/monitorCopy into all filter functions.
apps/tradinggoose/widgets/widgets/copilot/components/user-input/hooks/use-user-input-mentions.ts	Adds locale tracking and a locale-change effect to reload the currently open submenu; correctly guards with previousLocaleRef to avoid spurious reloads on initial mount.
apps/tradinggoose/widgets/widgets/copilot/components/user-input/components/mention-menu.tsx	Replaces all hardcoded English strings with localized copy; switches string-key option comparisons to stable internal IDs. No issues found.
apps/tradinggoose/widgets/widgets/copilot/workspace-entities.ts	Drops string-based mentionOption/submenuTitle fields; CopilotWorkspaceEntityMentionOption is now an alias for CopilotWorkspaceEntityKind.
apps/tradinggoose/widgets/widgets/copilot/components/user-input/hooks/use-user-input-mentions.test.tsx	New hook tests; the root-menu locale-change test asserts all MENTION_SUBMENUS are loaded but the implementation returns early when openSubmenuFor is null.
apps/tradinggoose/widgets/widgets/copilot/components/user-input/hooks/use-user-input-mention-sources.test.tsx	New source hook tests verifying block and workflow-block names are reloaded with updated localized labels after a locale switch.
apps/tradinggoose/widgets/widgets/copilot/components/user-input/mention-utils.test.ts	Expanded with multilingual filter tests covering accent-insensitive matching, localized trigger labels, and aggregated search.

Prompt To Fix All With AI

Fix the following 2 code review issues. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 2
apps/tradinggoose/widgets/widgets/copilot/components/user-input/hooks/use-user-input-mention-sources.ts:343-357
**Stuck loading spinner when locale changes mid-fetch for `workflow_blocks`**

The `blocks` fetch has a `useEffect([locale])` that resets `isLoadingBlocks` on locale change (line 349–352). The `workflow_blocks` fetch has no equivalent cleanup — only `useEffect([workflowId])` resets `isLoadingWorkflowBlocks`. If locale changes while `ensureWorkflowBlocksLoaded` is in-flight, the `finally` block's `if (latestWorkflowBlocksKeyRef.current === loadKey)` guard fires false (key mismatch), so `setIsLoadingWorkflowBlocks(false)` is skipped. Nothing else resets it until `workflowId` changes or the user closes and reopens the submenu. The workflow_blocks submenu will remain stuck on "Loading…" indefinitely after a mid-fetch locale switch.

### Issue 2 of 2
apps/tradinggoose/widgets/widgets/copilot/components/user-input/hooks/use-user-input-mentions.test.tsx:231-260
**Test assertion may not match the implementation**

The test expects `ensureSubmenuLoaded` to be called for every entry in `MENTION_SUBMENUS` after a locale change when the root menu is open (`openSubmenuFor === null`). However, the locale-change `useEffect` in `use-user-input-mentions.ts` returns early when `openSubmenuFor` is null (`if (previousLocale === locale || !showMentionMenu || !openSubmenuFor) return`), so only one `ensureSubmenuLoaded('workflow_blocks')` call from the preceding `handleInputChange` would have been recorded (and was cleared by `mockClear()`). If this test currently passes it is relying on behaviour not visible in the diff; if it is silently broken, it is not catching the preloading gap it was intended to cover.

_{Reviews (1): Last reviewed commit: "feat(copilot): localize mention labels a..." | Re-trigger Greptile}

[greptile-apps]

Stuck loading spinner when locale changes mid-fetch for workflow_blocks

The blocks fetch has a useEffect([locale]) that resets isLoadingBlocks on locale change (line 349–352). The workflow_blocks fetch has no equivalent cleanup — only useEffect([workflowId]) resets isLoadingWorkflowBlocks. If locale changes while ensureWorkflowBlocksLoaded is in-flight, the finally block's if (latestWorkflowBlocksKeyRef.current === loadKey) guard fires false (key mismatch), so setIsLoadingWorkflowBlocks(false) is skipped. Nothing else resets it until workflowId changes or the user closes and reopens the submenu. The workflow_blocks submenu will remain stuck on "Loading…" indefinitely after a mid-fetch locale switch.

Prompt To Fix With AI

This is a comment left during a code review.
Path: apps/tradinggoose/widgets/widgets/copilot/components/user-input/hooks/use-user-input-mention-sources.ts
Line: 343-357

Comment:
**Stuck loading spinner when locale changes mid-fetch for `workflow_blocks`**

The `blocks` fetch has a `useEffect([locale])` that resets `isLoadingBlocks` on locale change (line 349–352). The `workflow_blocks` fetch has no equivalent cleanup — only `useEffect([workflowId])` resets `isLoadingWorkflowBlocks`. If locale changes while `ensureWorkflowBlocksLoaded` is in-flight, the `finally` block's `if (latestWorkflowBlocksKeyRef.current === loadKey)` guard fires false (key mismatch), so `setIsLoadingWorkflowBlocks(false)` is skipped. Nothing else resets it until `workflowId` changes or the user closes and reopens the submenu. The workflow_blocks submenu will remain stuck on "Loading…" indefinitely after a mid-fetch locale switch.

How can I resolve this? If you propose a fix, please make it concise.

[greptile-apps]

Test assertion may not match the implementation

The test expects ensureSubmenuLoaded to be called for every entry in MENTION_SUBMENUS after a locale change when the root menu is open (openSubmenuFor === null). However, the locale-change useEffect in use-user-input-mentions.ts returns early when openSubmenuFor is null (if (previousLocale === locale || !showMentionMenu || !openSubmenuFor) return), so only one ensureSubmenuLoaded('workflow_blocks') call from the preceding handleInputChange would have been recorded (and was cleared by mockClear()). If this test currently passes it is relying on behaviour not visible in the diff; if it is silently broken, it is not catching the preloading gap it was intended to cover.

Prompt To Fix With AI

This is a comment left during a code review.
Path: apps/tradinggoose/widgets/widgets/copilot/components/user-input/hooks/use-user-input-mentions.test.tsx
Line: 231-260

Comment:
**Test assertion may not match the implementation**

The test expects `ensureSubmenuLoaded` to be called for every entry in `MENTION_SUBMENUS` after a locale change when the root menu is open (`openSubmenuFor === null`). However, the locale-change `useEffect` in `use-user-input-mentions.ts` returns early when `openSubmenuFor` is null (`if (previousLocale === locale || !showMentionMenu || !openSubmenuFor) return`), so only one `ensureSubmenuLoaded('workflow_blocks')` call from the preceding `handleInputChange` would have been recorded (and was cleared by `mockClear()`). If this test currently passes it is relying on behaviour not visible in the diff; if it is silently broken, it is not catching the preloading gap it was intended to cover.

How can I resolve this? If you propose a fix, please make it concise.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!