Amr fix - #104
Conversation
ElPsyKurisu
left a comment
ElPsyKurisu
left a comment
There was a problem hiding this comment.
Overall very nice, but please check the comments as we need to fix the virtual_keithley and ideally get a parity match between the AMR gui and IV gui
There was a problem hiding this comment.
Im assuming the live_plot= false turns off the second window popping up?
There was a problem hiding this comment.
i think it would be nice to have the same pause or stop capability of AMR, also by chance could we make the returned data more than just a flat line, assume you have like a resistor or something connected so it shows like a line or something
There was a problem hiding this comment.
So we should not have virtual_specific instrument. it should always be virtual_generic, aka virtual_sourcemeter in this case. So if possible could you rename it and make sure it follows the same conventions as the other virtual_instruments?
There was a problem hiding this comment.
another thing i dont think it should inherit from scpi, since we can technically have awgs that are not scpi
2 participants
Remove popup from AMR gui when running measurement. Resolves #100