Skip to content

Fix desktop toolbar dropdowns - #37

Merged
TrapEmAll merged 1 commit into
mainfrom
agent/fix-toolbar-dropdowns
Aug 11, 2026
Merged

Fix desktop toolbar dropdowns#37
TrapEmAll merged 1 commit into
mainfrom
agent/fix-toolbar-dropdowns

Conversation

@TrapEmAll

Copy link
Copy Markdown
Owner

What changed

  • Rebuild each top toolbar dropdown as a child of its own menubutton.
  • Keep explicit menu references for the lifetime of the desktop window.
  • Add a regression test that verifies every dropdown is owned and configured by the correct button.

Why

Tk requires a posted menu to belong to the menubutton that owns it. The toolbar previously created all menus under the root window, which left the File, View, Tools, and Help buttons visible but nonfunctional on Windows.

Validation

  • python tests.py (131 tests passed)
  • Ruff checks passed
  • Version consistency check passed
  • Python compile check passed

@TrapEmAll
TrapEmAll marked this pull request as ready for review August 11, 2026 10:51
@TrapEmAll
TrapEmAll merged commit a979780 into main Aug 11, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant