chore(docs): challenge the corpus with a product that has no agent record - #529
Conversation
yordis
commented
Aug 6, 2026
- Both corpora had frozen their conclusions without ever meeting a product that omits the agent record entirely, so the stated invariants risked being artifacts of the sample rather than real convergence.
- IronClaw is that counterexample, and its evidence forces the synthesis to separate roles that must exist from resources that happen to hold them, and to name lost-update safety as distinct from append-only-ness.
- Its revisions are marked inline rather than folded silently, so a reader can still see which claims were decision-time input and which were revised after.
- Corpus counts in the prose were dropped because they force an unrelated edit every time a dossier lands.
…cord Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
PR SummaryLow Risk Overview The main substantive change is post-freeze synthesis revision, not silent rewrites: both Housekeeping in the same PR: corpus prose drops fixed product counts (so new dossiers do not force count churn), session-store index status text is generalized, and citation-verification wording no longer hard-codes “eighteen products.” Reviewed by Cursor Bugbot for commit 5560fc3. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
Warning Review limit reached
Next review available in: 48 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
WalkthroughThe PR adds IronClaw to the research corpus, creates agent-platform and session-store dossiers, and updates both synthesis documents with IronClaw’s identity, runtime, storage, concurrency, lifecycle, and subagent findings. ChangesIronClaw research integration
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/research/session-store/index.md`:
- Around line 60-64: The sweep-status prose in
docs/research/session-store/index.md:60-64 must remove the hard-coded citation
total and manually maintained remaining-dossier list, replacing them with
invariant wording or repository-generated values. Also update
docs/research/agent-platform/synthesis.md:435-437 to replace “the eighteenth
product” with product-neutral wording; preserve the surrounding meaning without
embedding corpus-size-dependent counts.
In `@docs/research/session-store/products/ironclaw/index.md`:
- Around line 301-302: Update the method count in the SessionThreadService
description from 32 to 34, while keeping the stated count of 16 required methods
unchanged.
In `@docs/research/session-store/synthesis.md`:
- Line 4: Update the later sentence near the “nine dossiers” reference to remove
the fixed corpus count while preserving its meaning and surrounding wording.
- Around line 519-534: The comparison in the “Industry’s answer” paragraph
overstates what a single expected-version append provides. Narrow the claim to
lost-update and cross-record invariant protection, or explicitly state that
lease ownership, heartbeat renewal, expiry, and pre-side-effect admission
require modeled aggregate lease transitions with a lease protocol; do not imply
expected-version append alone supplies those active-run protections.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 5df3eb09-3636-40bc-aa6c-fdb632768d96
📒 Files selected for processing (7)
docs/research/README.mddocs/research/agent-platform/index.mddocs/research/agent-platform/products/ironclaw.mddocs/research/agent-platform/synthesis.mddocs/research/session-store/index.mddocs/research/session-store/products/ironclaw/index.mddocs/research/session-store/synthesis.md
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>