Add type aliases#8
Open
lukeschmitt-tr wants to merge 1 commit intographite-base/8from
Open
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
lukeschmitt-tr
force-pushed
the
04-15-auto-detect_dataset_types
branch
from
b3b0c65 to
5de06ea
Compare
lukeschmitt-tr
force-pushed
the
04-15-add_type_aliases
branch
from
3254290 to
12b6778
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for short --type aliases when uploading/importing datasets, improving CLI ergonomics while preserving strict validation via DatasetType.
Changes:
- Introduced
--typealias resolution (lerobot→lerobot_v3,mcap→trossenmcap) with centralized parsing/validation. - Updated dataset type resolution messaging to mention aliases.
- Added CLI tests covering alias acceptance and invalid
--typerejection.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/trossen_cloud_cli/commands/datasets.py |
Adds alias mapping + parsing helper and wires it into upload and import-hf. |
tests/test_validators.py |
Adds CLI tests verifying alias handling and invalid type errors. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lukeschmitt-tr
force-pushed
the
04-15-auto-detect_dataset_types
branch
from
5de06ea to
b7c834b
Compare
lukeschmitt-tr
force-pushed
the
04-15-add_type_aliases
branch
from
12b6778 to
102164b
Compare
| print_success(f"Downloaded to {local_path}") | ||
|
|
||
| dataset_type = _resolve_dataset_type(local_path, dataset_type) | ||
| dataset_type = _resolve_dataset_type(local_path, _parse_dataset_type(dataset_type_str)) |
Comment on lines
+121
to
+123
| require_auth() | ||
|
|
||
| dataset_type = _resolve_dataset_type(path, dataset_type) | ||
| dataset_type = _resolve_dataset_type(path, _parse_dataset_type(dataset_type_str)) |
Comment on lines
265
to
268
| print_success(f"Downloaded to {local_path}") | ||
|
|
||
| dataset_type = _resolve_dataset_type(local_path, dataset_type) | ||
| dataset_type = _resolve_dataset_type(local_path, _parse_dataset_type(dataset_type_str)) | ||
|
|
lukeschmitt-tr
force-pushed
the
04-15-add_type_aliases
branch
from
102164b to
b5054a9
Compare
lukeschmitt-tr
force-pushed
the
04-15-auto-detect_dataset_types
branch
from
b7c834b to
74c6523
Compare
lukeschmitt-tr
changed the base branch from
04-15-auto-detect_dataset_types
to
graphite-base/8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add aliases for dataset types.