Add timecode sync, update readme#9
Merged
abhichothani42 merged 7 commits intomainfrom May 5, 2026
Merged
Conversation
abhichothani42
requested review from
Copilot,
lukeschmitt-tr and
shantanuparab-tr
There was a problem hiding this comment.
Pull request overview
This PR updates GoPro data-collection documentation and makes the timecode sync tool self-hosted within the repo, while also adjusting parts of the SLAM pipeline and visualization utilities to support new directory/tag conventions.
Changes:
- Vendor and document a self-hosted GoPro Labs timecode sync QR page under
assets/timecode_sync/. - Update SLAM batch localization to discover
mapping_*directories formap_atlas.osa. - Extend ArUco visualization tag labels for dual-gripper support and update docs/assets (
README.md, screenshot), plus ignore.python-versionanduv.lock.
Reviewed changes
Copilot reviewed 6 out of 9 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
scripts/visualize_aruco_video.py |
Extends TAG_LABELS to support dual-gripper tag IDs and new label naming. |
scripts/scripts_slam_pipeline/03_batch_slam.py |
Changes default map lookup to search for mapping_* directories. |
assets/timecode_sync/index.html |
Adds self-hosted timecode sync QR page (JS/HTML). |
assets/timecode_sync/style.css |
Adds styling for the timecode sync page (includes external font import). |
assets/timecode_sync/qrcodeborder.js |
Vendors QR code generation library used by the page. |
assets/timecode_sync/jquery.min.js |
Vendors jQuery (very old version). |
assets/camera_settings_saved_check.jpg |
Adds screenshot referenced by README for GoPro settings confirmation. |
README.md |
Updates GoPro setup instructions and points timecode sync to the local HTML asset. |
.gitignore |
Ignores .python-version and uv.lock. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 10 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lukeschmitt-tr
approved these changes
May 4, 2026
Contributor
Author
|
Updated serve_timecode_sync.py to use logging instead print, click for argument parsing, address copilot comments. ready for review |
lukeschmitt-tr
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Update GoPro setup documentation, self-hosts the timecode sync tool, fixes mapping directory lookup, and extends ArUco tag labels for dual-gripper support.
What changed?
03_batch_slam.pyto search for amapping_*directoryTAG_LABELSinvisualize_aruco_video.pyto include tag IDs 6 and 7 for a second gripper (gripper_1), and renamed existing labels to usegripper_0as a prefix..python-versionanduv.lockto.gitignore.