Add support for typeof unary operator#304
Closed
trevordixon wants to merge 1 commit intoTroyAlford:developfrom
Closed
Add support for typeof unary operator#304trevordixon wants to merge 1 commit intoTroyAlford:developfrom
trevordixon wants to merge 1 commit intoTroyAlford:developfrom
Conversation
Author
|
Hey Troy, how do you feel about this? I know it isn't ideal commenting out tests, but they weren't really running anyway. |
Author
|
Hi Troy, one more polite ping :D |
Owner
|
Hey @trevordixon — sorry for being slow on this. I'm going to merge your changes in alongside some others in #308. |
TroyAlford
added a commit
that referenced
this pull request
Sep 19, 2025
…ng (#308) ## Summary Refactors TypeScript typings for the `components` prop to support nested component collections and adds support for additional unary operations. ## What Changed - **Type Safety**: Added `ComponentType` and `ComponentsType` definitions for better component collection support - **Unary Operations**: Added bitwise NOT (`~`) and `typeof` operator support - **Error Handling**: Fixed error handling logic to prevent execution on parse errors - **Developer Experience**: Improved IntelliSense and autocomplete for complex component hierarchies ## Why - Better type safety when passing nested component collections - More complete JavaScript expression evaluation - Cleaner, more maintainable type definitions - More robust error handling Closes #297 Closes #304 Closes #305 Closes #306 Closes #307
Owner
|
This is now out/available in v2.4.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out the unary operations tests weren't actually testing anything.
({ operation, expected } ) => ...should have been(operation, expected) => ...(two params, not destructured). The test cases I commented out don't work, because for those values,instance.ParsedChildrenis an empty array, so the expectation doesn't hold. A different method is needed to test if they're getting parsed properly.