fix: multi-artist handling fixes from code review#95
Merged
Conversation
- resolveAndOpen: split multi-artist hint so album resolution can match candidates listing artists individually (was a silent no-op) - aggregate: drop separator-only artist strings instead of creating a phantom artist row - useArtistImage: accept defaults blob and pass it from ArtistMediaCard so YT Music artist images can load - extract shared splitArtists() helper into itemHelpers Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release details
Fixed
defaultsblob when the item carries one, so services that require it (YT Music) return the real artist photo instead of always falling back to album art.Internal
splitArtists()helper intorenderer/src/lib/itemHelpers.ts, replacing duplicated comma-splitting logic inLeaderboardPanel,AlbumPanel, anduseResolveAndOpen.Verification
npm run typecheckclean (main + renderer),tsc --noEmitclean inserver/npm run test:run: 442/442 tests passing across 35 files🤖 Generated with Claude Code