feat: V Rising server updates, ci, documentation#113
Open
dmirtillo wants to merge 2 commits intoTrueOsiris:mainfrom
Open
feat: V Rising server updates, ci, documentation#113dmirtillo wants to merge 2 commits intoTrueOsiris:mainfrom
dmirtillo wants to merge 2 commits intoTrueOsiris:mainfrom
Conversation
This commit brings in several enhancements from a heavily modified fork, consolidating them into a single clean commit for review. Included changes: - Refactored Dockerfile for improved architecture and Wine v11 support. - Implemented robust start.sh server initialization and Steam license acceptance. - Added GitHub Actions for Dependabot, automated updates (Wine/V Rising), and registry pruning. - Overhauled documentation, moving monolithic README into a structured docs/ folder. - Added automated E2E startup tests (test-startup.sh). - Enforced LF line endings and fixed container healthchecks.
Update README, CHANGELOG, and all documentation files to point back to the original author's repository (TrueOsiris/docker-vrising) and Docker Hub image (trueosiris/vrising) in preparation for upstream PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Synchronize V Rising Server Improvements
Hi @TrueOsiris ,
I've been using your V Rising Docker container for quite some time to host a community server. Recently, I wanted to update it to the latest Ubuntu + Wine since the older image was no longer compatible with my setup.
I reached out via email a little while ago, but I know how busy maintaining open-source projects can get! I've been working on my fork and wanted to contribute these improvements back to the community.
Since I heavily modified my local Git history while working on these changes, I've consolidated everything into this single, clean PR branch to make it easy for you to review and merge without any messy Git history conflicts.
Summary of Changes
This PR brings in several enhancements focused on stability, automation, and documentation:
Core Architecture & Container Updates
start.sh: Enhanced server initialization, robustly handled the SteamCMD platform override, and fixed the Steam license acceptance process.CI/CD & Automation
.github/dependabot.yml) to keep GitHub Actions dependencies up to date.scripts/test-startup.shanddocker-compose.test.yml) to verify the container starts successfully.Documentation Overhaul
docs/folder for better readability.CHANGELOG.mdfile to track changes more easily.Testing
I've been running these changes on my community server and they have been stable. The newly added E2E tests (
test-startup.sh) also verify that the server initializes correctly in the container.I hope you find these contributions helpful! Please let me know if you have any feedback or if you'd like me to tweak anything before merging.
Thanks for maintaining this project!