fix: upgrade node version and consolidate trustvc package#5
Conversation
📝 WalkthroughWalkthroughReplaces imports and dependency from Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
jest.config.js (1)
6-35:⚠️ Potential issue | 🟠 MajorAdd
@trustvcto Jest's transform whitelist.The project uses
@trustvc/trustvcand related packages as direct dependencies (e.g.,@trustvc/trustvc@^2.5.2), imported in both source files and tests (e.g.,src/utils.test.tsx,src/utils.ts,src/types.ts). However, the currenttransformIgnorePatternsonly whitelists@tradetrust-ttpackages. Jest will skip transforming@trustvc/*packages, which can break tests if they contain TypeScript or ESM code that requires transformation.Suggested update
- transformIgnorePatterns: ["node_modules/?!(`@tradetrust-tt`).*/"], + transformIgnorePatterns: ["node_modules/?!(`@trustvc`|@tradetrust-tt).*/"],
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/ci.yml (1)
16-21:⚠️ Potential issue | 🔴 CriticalUpgrade
actions/setup-node@v3to v4 — v3 is incompatible with current GitHub-hosted runners.
actions/setup-node@v3runs as a Node16-based action, which was removed from GitHub-hosted runners on November 12, 2024. The workflow will fail on hosted runners. Upgrade toactions/setup-node@v4(Node20-based) to support Node 24.x.Required update
- - uses: actions/setup-node@v3 + - uses: actions/setup-node@v4 with: node-version: ${{ matrix.node-version }}
🤖 Fix all issues with AI agents
In @.github/workflows/ci.yml:
- Around line 31-33: The Release step currently runs npx semantic-release@19.0.5
which is incompatible with Node 22/24; update the command in the Release step
(the line invoking "npx semantic-release@19.0.5 --branches master") to use
semantic-release v25.0.0 or later (e.g., npx semantic-release@^25.0.0) and
ensure the workflow sets up a compatible Node runtime by adding/updating an
actions/setup-node step to use Node >=22.14.0 (for Node 22) or >=24.10.0 (for
Node 24).
Summary by CodeRabbit
Chores
Tests
Documentation
Examples