Skip to content

Added share button#1046

Merged
peterzimon merged 2 commits intomainfrom
add-share-button
Apr 15, 2026
Merged

Added share button#1046
peterzimon merged 2 commits intomainfrom
add-share-button

Conversation

@minimaluminium
Copy link
Copy Markdown
Member

ref https://linear.app/ghost/issue/FEA-613/update-themes-to-include-share-button

We're introducing native share button feature in Portal and this adds share button support to official themes.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 10, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3b43af85-2ffe-4b34-9f5c-d626985f8c83

📥 Commits

Reviewing files that changed from the base of the PR and between aa652b4 and c0cc42f.

⛔ Files ignored due to path filters (1)
  • assets/built/screen.css.map is excluded by !**/*.map
📒 Files selected for processing (2)
  • assets/built/screen.css
  • assets/css/screen.css

Walkthrough

This pull request adds a new share button to the post template and corresponding styles. It inserts an anchor with class gh-button-share into the post header after the byline. CSS changes introduce the .gh-button-share rules (base appearance, hover state) plus dark-mode and prefers-color-scheme: dark overrides, update .article-byline to include align-items: center and gap: 16px, and expand the --font-sans stack to include Fira Sans and Droid Sans.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Added share button' directly and clearly describes the main change in the pull request, which adds share button support across CSS styling, configuration, and template files.
Description check ✅ Passed The description is related to the changeset, referencing the feature work (FEA-613) and explaining that the PR adds share button support to official themes to align with Portal's native share button feature.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch add-share-button

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

# Conflicts:
#	assets/built/screen.css
#	assets/built/screen.css.map
@peterzimon peterzimon merged commit fd9a766 into main Apr 15, 2026
1 check passed
@peterzimon peterzimon deleted the add-share-button branch April 15, 2026 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants