Skip to content

Remove redundant devDependencies automerge override#1822

Open
ErisDS wants to merge 1 commit intomainfrom
remove-redundant-automerge-override
Open

Remove redundant devDependencies automerge override#1822
ErisDS wants to merge 1 commit intomainfrom
remove-redundant-automerge-override

Conversation

@ErisDS
Copy link
Copy Markdown
Member

@ErisDS ErisDS commented Apr 9, 2026

Summary

  • Removes the repo-local Renovate rule that overrides automergeType to branch for devDependencies
  • The org-wide config (tryghost/renovate-config) already automerges all dependency types using automergeType pr, making this local override redundant
  • Aligning with the org default simplifies the config and ensures consistent behaviour across repos

Test plan

  • Verify Renovate still automerges devDependency updates (now via PR instead of branch)
  • Monitor that dependency update behaviour remains as expected

…nfig

This rule was carried over from the old @TryGhost:automergeDevDependencies
npm preset during the Jan 2024 migration to GitHub-hosted presets. It set
automergeType to 'branch' which triggers CI on every push attempt, unlike
the org default of 'pr'. The org config now automerges all dependency types
via PR, making this override both redundant and more expensive.
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 9, 2026

Walkthrough

The pull request removes a packageRules entry from the Renovate configuration that previously enabled automatic merging for all devDependencies. The removed rule had automerge: true and automergeType: "branch" settings. The remaining packageRules entries for other dependencies (rollup/plugins, lexical, vitest) remain unchanged. A minor whitespace adjustment is also applied to the JSON structure.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Remove redundant devDependencies automerge override' directly and accurately describes the main change: removing a redundant Renovate configuration rule for devDependencies automerge.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The pull request description clearly relates to the changeset, explaining the removal of a redundant Renovate rule and providing rationale for the change.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch remove-redundant-automerge-override

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
.github/renovate.json (1)

8-14: ⚠️ Potential issue | 🟡 Minor

Fix indentation on line 9 for consistent JSON formatting.

The opening brace for the first packageRules entry is missing proper indentation. All other entries in the array use 4-space indentation before {, but this one is flush left.

Proposed fix
   "packageRules": [
-{
+    {
       "groupName": "rollup + plugins",
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.github/renovate.json around lines 8 - 14, The JSON has inconsistent
indentation for the first packageRules entry: the opening brace for the object
that contains "groupName": "rollup + plugins" and "packagePatterns" is not
indented to match the other array entries; update the formatting so the brace
and its object fields (the packageRules array element with groupName and
packagePatterns) use the same 4-space indentation as the other entries to
restore consistent JSON formatting.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In @.github/renovate.json:
- Around line 8-14: The JSON has inconsistent indentation for the first
packageRules entry: the opening brace for the object that contains "groupName":
"rollup + plugins" and "packagePatterns" is not indented to match the other
array entries; update the formatting so the brace and its object fields (the
packageRules array element with groupName and packagePatterns) use the same
4-space indentation as the other entries to restore consistent JSON formatting.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 242379bb-2eea-4b88-80cb-4a2e1f1d8200

📥 Commits

Reviewing files that changed from the base of the PR and between 49bbac5 and d6e79bf.

📒 Files selected for processing (1)
  • .github/renovate.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant