Fix LinkedIterator.remove() for the last live element - #10
Open
HaHaWTH wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LinkedIterator.findNext() updates
curronly when it finds another live node. When next() returns the last live element,currremains null or points to the previously returned node, causing the iterator to remove the wrong element.Logs
Exception found on Paper: https://mclo.gs/SlxTMFc
Minimal reproduce code
Fix
Record the current
nextnode before clearing the final iterator state. This maintains exact-node O(1) removal and keeps MTQueue's concurrent semantics.